Repository navigation
Bound nested context-menu ancestry and handoff - #530
Merged
Merged
Conversation
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebScene retains child documents beneath iframe owners for native layout, but DOM ancestry must stop at the child document. Unchanged Code OSS context-menu code walks
closest('[data-vscode-context]'), parent elements, and the event path; crossing into the outer document can leak host context and dispatch beyond the webview boundary.This bounds
Element.closest(), native event ancestry, andcomposedPath()at the dispatch realm's document root. Authored native and browser sources cover prior cancellation, exact child-over-parent context merging, outer-frame isolation, child-local coordinates, handler cancellation, and visibility-class set/clear.Only
git diff --checkran under the current implementation-first policy. Chromium/native execution, lifecycle, performance, accessibility, package, and unchanged-product evidence remain deferred in #268.Closes #529
Progresses #268