Render CSS masks, filters, clip paths, and backdrop effects in retained scenes #256

Activity

1. wieslawsoltes

   added

   vscode-oss/plannedPlanned for the AppScene/WebScene VS Code OSS integrationPlanned for the AppScene/WebScene VS Code OSS integration

   on Sep 17, 2026
2. wieslawsoltes

   added a parent issue on Sep 17, 2026

   • [Epic] CSS features, compatibility, validation, and performance #235
3. wieslawsoltes commented on Sep 17, 2026

   

   wieslawsoltes

   on Sep 17, 2026

   CollaboratorAuthor

   More actions

   Implementation start boundary (2026-09-17):

   • Branch: feature/css-retained-effects-256, from exact current main ee6efa9f71fcbd9342fc037c005f5396c4c40e38 (merged Qualify forced-colors, system colors, focus visuals, and motion preferences #255/Add host CSS accessibility preference state #279).
   • External structural-invalidation PR Optimize structural CSS invalidation and DOM mutation checkpoints #245 is at exact head 51fef1f23169b7bfcb87ae67a7388c74e422fafd with 58 GitHub-reported paths.
   • Render CSS masks, filters, clip paths, and backdrop effects in retained scenes #256 will maintain zero overlap with those 58 paths and will not modify Optimize structural CSS invalidation and DOM mutation checkpoints #245's branch, checks, structural matching, mutation checkpoints, or component WPT profile.
   • Initial focused slice follows stack item 1: product-neutral syntax, computed-value, capability-boundary, browser/native contracts for mask-*, clip-path, filter, and backdrop-filter. Unsupported paint functions remain explicit until a later retained-scene command/resource slice proves them.
   • The first implementation will use a dedicated profile/target and bounded artifacts. Retained-scene command/resource work will proceed only after the syntax boundary is executable and after another live Optimize structural CSS invalidation and DOM mutation checkpoints #245 overlap audit.

   #257 remains deferred until #245 is reconciled.
4. wieslawsoltes commented on Sep 17, 2026

   

   wieslawsoltes

   on Sep 17, 2026

   CollaboratorAuthor

   More actions

   Final ownership audit before commit:

   • external PR Optimize structural CSS invalidation and DOM mutation checkpoints #245 exact head: 5c72775651bc56505e0ef4370cb5265afb4c9605
   • PR Optimize structural CSS invalidation and DOM mutation checkpoints #245 changed paths: 64
   • proposed Render CSS masks, filters, clip paths, and backdrop effects in retained scenes #256 changed paths: 15
   • intersection: 0/64

   This first #256 slice stays limited to product-neutral effect syntax, CSSOM/computed values, mutation, allocation, and cleanup. Retained-scene mask, clip, filter, and backdrop painting remains explicitly unqualified for later #256 work.
5. wieslawsoltes commented on Sep 17, 2026

   

   wieslawsoltes

   on Sep 17, 2026

   CollaboratorAuthor

   More actions

   First #256 slice merged through PR #282 at 2cf805f1fa8abd5ac56d92d057272a0341aa25b8.

   Qualified in this slice:

   • mask longhand, clip-path, filter, and backdrop-filter syntax/computed values;
   • invalid CSSOM write retention and live class-mutation refresh;
   • native and Chrome contract parity: 1/1 documents, 10/10 subtests on each;
   • 4,096 descendants / 100 cycles / 200 states in 11,171.1 ms, at most 1 retained node, zero settled frame demand, and 7,727,735 accounted peak textual-style bytes under a 32 MiB bound;
   • portable CSS 377/377 on both target frameworks, portable V8, docs, Linux CI, original Native Linux contracts, and independent native-only Linux SDK.

   Final external ownership audit used PR #245 head 5c72775651bc56505e0ef4370cb5265afb4c9605: 64 paths there, 15 paths in #282, 0/64 overlap.

   This issue remains open with vscode-oss/planned: retained-scene mask/clip/filter/backdrop painting and visual acceptance are still unqualified and remain in the later #256 stack. Issue #257 remains deferred pending external #245 reconciliation.

   The rebased checks also confirmed the isolated #255 ABI-contract repair merged through #283 at de85116adcba2cf231c7a731ae82aebc489cf116.
6. wieslawsoltes commented on Sep 17, 2026

   

   wieslawsoltes

   on Sep 17, 2026

   CollaboratorAuthor

   More actions

   Retained-painting follow-up starts from exact current main aa786c0ea2bbd21599f33caf3795c0eacc19ace3 on feature/css-retained-painting-256.

   The post-#282 gap is exact: effect strings reach computed style and memory accounting, but webscene_native_dom_scene.inc never reads effect_values; therefore clip-path, masks, foreground filters, and backdrop filters emit no retained-scene commands. The smallest independent paint slice is rectangular clip-path: inset(...), because scene kinds 12/13 and every current presenter already provide balanced retained rectangular clipping. This slice can qualify clip ordering without defining new ABI commands or touching #245.

   Initial five-path candidate:

   • retained-scene emission in webscene_native_dom_scene.inc;
   • scene-command/performance/lifecycle assertions in the existing native_css_effect_values_tests.cpp target;
   • a new product-neutral inset-clip reftest and reference;
   • a dedicated profile.

   Ownership audit: #245 exact head d95831cc2018b6ea950670261f6a927bbd9f31ec, 77 paths, 0/5 overlap. The local-only #286 four-path candidate also has 0/5 overlap. I will establish Chromium/native pixel and exact scene-command baselines before implementation. Masks, circle/ellipse/polygon/path clips, filters, and backdrop isolation stay explicitly unclaimed.
7. wieslawsoltes commented on Sep 17, 2026

   

   wieslawsoltes

   on Sep 17, 2026

   CollaboratorAuthor

   More actions

   Local candidate committed as 5034f88d67edfdaf303e09009dcf33c04bf6737c on feature/css-retained-painting-256 (not pushed; no PR).

   This closes the smallest remaining retained-painting slice after #282: strict rectangular clip-path: inset(...) now emits balanced existing scene clip commands around the element and descendants. It supports 1–4 px/% values and unitless zero, resolves percentages against the border box, and rejects unsupported shapes/units/round without changing the scene ABI or presenters. Parsing in the scene hot path is allocation-free. Transform nesting is asserted as transform begin → clip begin → paint → clip end → transform end.

   Focused evidence:

   • Release native contract: PASS; 4,096 effects, 100 scale cycles in 18,870.5 ms, 4,099 textual-style entries / 7,727,735 bytes, 12,294 commands / 639,288 bytes, 4,096 balanced clips and fills, transform/clip nesting true.
   • Publication/lifecycle: PASS; one live mutation node, 100 cycles / 200 acknowledged publications in 4,136.77 ms, settled frame demand 0, retained DOM-node delta 0 after cleanup.
   • Exact visual oracle: PASS 1/1 in Chromium and native, 240×160 fixture, 0 differing pixels; covers pixel and percentage insets, overflowing descendants, and class mutation.
   • The 25-second scale ceiling reflects current-main baseline evidence: the same Release workload with retained clip emission temporarily disabled measured 19,523.9 ms; the final allocation-free implementation measured 18,870.5 ms.

   Final collision audit immediately before commit: live #245 head 4f9c3ba3e1926a3d6b93db3586834c167541f6ba, 86 paths, overlap 0/5. Local #286 candidate overlap is also 0/5.

   Remaining owner split: masks, circle/ellipse/polygon/path clips, foreground filters, backdrop effects, and effect-driven stacking/isolation remain separate follow-ups. This tranche adds no implementation in those owners.
8. wieslawsoltes commented on Sep 17, 2026

   

   wieslawsoltes

   on Sep 17, 2026

   CollaboratorAuthor

   More actions

   Focused retained-painting PR opened: #290.

   • rebased cleanly onto current main 4040058e after Optimize structural CSS invalidation and DOM mutation checkpoints #245 merged;
   • commit 20b5480b changes five paths, with zero overlap against Optimize structural CSS invalidation and DOM mutation checkpoints #245's 86-path set;
   • certification-enabled Release native gate passes 1/1 in 17.15 seconds after rebase;
   • native reftest and Chromium oracle pass 1/1 with zero differing pixels;
   • scene command, transform/clip nesting, 4,096-node scale, 100-cycle publication/lifecycle, settled-frame, and retained-node assertions pass.

   #290 covers rectangular clip-path: inset(...) painting only. The parent remains open for nonrectangular clips, masks, filters, backdrop effects, and stacking/isolation.
9. wieslawsoltes commented on Sep 17, 2026

   

   wieslawsoltes

   on Sep 17, 2026

   CollaboratorAuthor

   More actions

   Rectangular retained-painting PR #290 merged to main at 140ec345 after its focused native Linux workflow passed the original document/compiler contracts and independent native-only Linux SDK. The rebased local certification-enabled Release gate passed in 17.15 seconds, and native/Chromium visual comparison passed 1/1 with zero differing pixels. The issue remains open for nonrectangular clips, masks, filters, backdrop effects, and effect-driven stacking/isolation.
10. wieslawsoltes

    added a sub-issue on Sep 18, 2026

    • Render centered CSS circle clip paths in retained scenes #449
11. wieslawsoltes commented on Sep 18, 2026

    

    wieslawsoltes

    on Sep 18, 2026

    CollaboratorAuthor

    More actions

    Focused retained-paint child #449 is complete through PR #451 at merge 3813a31772917655f71be8a15b04aeb096a049d8 (source 8ffbd20c99fb4d8a75cd1a4cf52df599495ca791).

    The retained scene now paints centered clip-path: circle(<length-or-percentage>) shapes. Percentages use the CSS normalized diagonal, and the resolved circle is emitted as balanced existing rounded clip commands around the element and descendant paint. Transform and opacity ordering remains unchanged. The change is one source file and adds no ABI command, capability bit, resource type, or presenter change.

    The slice deliberately leaves positioned circles, radius keywords, ellipses, polygons, paths, masks, foreground filters, backdrop effects, and effect-driven isolation open. In particular, unchanged Code OSS's Markdown diff indicator uses polygon(...); that needs a separate representation rather than an approximation through rounded clips.

    Implementation throughput was the explicit priority. Tests, browser/native pixel contracts, performance/lifecycle benchmarks, hosted checks, CI monitoring, and exact-package visual acceptance were skipped and remain validation debt. No broader support or release claim is made.
12. wieslawsoltes

    added a sub-issue on Sep 18, 2026

    • Render Code OSS polygon clip paths in retained scenes #456
13. wieslawsoltes commented on Sep 18, 2026

    

    wieslawsoltes

    on Sep 18, 2026

    CollaboratorAuthor

    More actions

    Focused Code OSS polygon child #456 is complete through PR #458 at merge a9f309c8ff80d701ef34e66aece8441e0f8f7fb6 (source bdcab00337e0f9035a50b44efa8f84344e62cc64).

    The retained scene now paints the unchanged Code OSS Markdown diff indicator's six-point clip-path: polygon(...). Native emission accepts a bounded default-fill-rule subset of 3–64 px/%/zero point pairs, resolves them against the border box, and stores one closed SVG path. Existing clip kind 12 uses an opt-in top flag bit plus the scene string index; kind 13 remains the balanced end. Avalonia and Uno use the shared Skia path clip, and Flutter uses its existing path parser. Existing inset/circle clips keep their prior zero-flag rounded geometry.

    This adds no scene struct, version, capability, or command-kind change. Fill-rule arguments, calc() and other units, ellipse/path/url clips, masks, foreground filters, backdrop effects, and effect-driven isolation remain open.

    Implementation throughput was the explicit priority. Tests, browser/native pixel contracts, performance/lifecycle benchmarks, hosted checks, CI monitoring, and exact-package visual acceptance were skipped and remain validation debt. No broader support or release claim is made.
14. wieslawsoltes

    added a sub-issue on Sep 18, 2026

    • Render Code OSS foreground brightness filters #463
15. wieslawsoltes commented on Sep 18, 2026

    

    wieslawsoltes

    on Sep 18, 2026

    CollaboratorAuthor

    More actions

    Focused foreground-filter child #463 is complete through PR #464 at merge d27290970ef4913b89a083da89a220726ee5e29b (source 88a820091f131738115790d8e50c534a473c98d6).

    The retained scene now paints single-function filter: brightness(<number-or-percentage>) values used by unchanged Code OSS release notes, issue reporter, Chat status/debug, and dictation surfaces. Native emission accepts a bounded 0–10 multiplier, wraps the element and descendants in the existing kind 30/31 group, and marks non-none foreground filters as atomic stacking contexts. Kind 30's top flag bit selects brightness and stroke_width carries the multiplier; zero-flag opacity groups retain their existing behavior. Avalonia/Uno and Flutter apply equivalent RGB color matrices.

    This adds no scene struct, version, capability, or command-kind change. Compound filters, filter animation/interpolation, blur and expanded damage, other filter functions, masks, backdrop sampling, and remaining isolation work stay open.

    Implementation throughput was the explicit priority. Tests, browser/native pixel contracts, performance/lifecycle benchmarks, hosted checks, CI monitoring, and exact-package visual acceptance were skipped and remain validation debt. No broader support or release claim is made.
16. 4 remaining items

    Load more

17. wieslawsoltes commented on Sep 18, 2026

    

    wieslawsoltes

    on Sep 18, 2026

    CollaboratorAuthor

    More actions

    Foreground blur slice #485 / PR #486 is merged at 9c6e3b98. The epic body now records the completed retained blur path and the remaining order: compound/function-valued filters, damage expansion, masks, backdrop sampling, remaining clip shapes, then cumulative visual/performance/memory/package/CI qualification.
18. wieslawsoltes

    added sub-issues on Sep 19, 2026

    • Render bounded compound foreground filter lists #487
    • Resolve functional blur lengths in retained filters #489
    • Expand localized damage for retained foreground blur #491
    • Render explicit ellipse clip paths in retained scenes #493
    • Render single linear-gradient CSS masks #497
    • Expand CSS mask shorthands into retained longhands #499
    • Render URL-backed SVG masks in retained scenes #500
    • Render bounded backdrop blur and saturation in retained scenes #503
    • Render CSS path() and local SVG URL clip paths #504
    • Render radial and multiple-layer CSS masks #505
    • Implement exclude and WebKit xor mask compositing #506
    • Load raster and controlled asynchronous CSS mask resources #507
    • Complete Flutter SVG mask geometry parity #508
    • Assert mask transparency by alpha across Skia profiles #635