Skip to content

Implement FileReader over native Blob bytes - #135

Merged
wieslawsoltes merged 1 commit into
feature/performance-timeline-code-ossfrom
feature/file-reader-native-blob
Sep 16, 2026
Merged

wieslawsoltes merged 1 commit into
feature/performance-timeline-code-ossfrom
feature/file-reader-native-blob

Conversation

@wieslawsoltes

@wieslawsoltes wieslawsoltes commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Problem and change

Code OSS consumes binary WebSocket messages as Blob values through FileReader. The runtime preserved Blob bytes but lacked FileReader.

This layer adds asynchronous FileReader state, events, abort and error behavior, and exact ArrayBuffer, text, binary string, and data URL reads over native Blob bytes. It installs per supported realm without replacing a complete host implementation.

Closes #73. The equivalent implementation remains in draft consolidation PR #76.

Cumulative validation

  • Performance layer d727fe33; exact head 391d4f54
  • Cumulative Release V8 native engine build
  • RuntimeCompatibility suite passes 25/25
  • Focused native websocket-file-reader filter: 10/10 local passes at 114-118 ms
  • Persisted 8 MiB exact-byte performance gate completes in 33.5 ms within the 3,000 ms budget
  • Ordered events, consecutive reads, concurrent-read failure, abort, real errors, byte identity, and lifecycle are covered
  • git diff --check

Native GitHub stack #159

  1. Implement retained Performance Timeline for Code OSS #134 — Performance Timeline (Implement retained Performance Timeline required by Code OSS startup #72)
  2. Implement FileReader over native Blob bytes #135 — current layer — FileReader over native Blob bytes (Implement FileReader over native Blob bytes for Code OSS WebSockets #73)
  3. Implement mutable stylesheet CSSOM for Monaco #136 — cumulative top — mutable stylesheet CSSOM (Implement mutable stylesheet CSSOM for Monaco and Code OSS #74)

Only the cumulative top PR receives remote validation. Merge all layers atomically through Stack #159 after the top related checks pass.

@wieslawsoltes
wieslawsoltes force-pushed the feature/file-reader-native-blob branch from 4108056 to 391d4f5 Compare September 16, 2026 20:24
@wieslawsoltes
wieslawsoltes marked this pull request as ready for review September 16, 2026 20:27
@wieslawsoltes
wieslawsoltes merged commit 5a13311 into main Sep 16, 2026
3 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement FileReader over native Blob bytes for Code OSS WebSockets

1 participant