Repository navigation
Keep captured Performance methods on one timeline - #130
Closed
wieslawsoltes wants to merge 3 commits into
Closed
wieslawsoltes wants to merge 3 commits into
wieslawsoltes wants to merge 3 commits into
Conversation
wieslawsoltes
force-pushed
the
fix/performance-method-timeline
branch
from
September 16, 2026 09:35
eb5b99f to
d17aacc
Compare
Collaborator
Author
|
Closing this older isolated review as superseded by merged native Stack #159. PR #134 carries the corrected retained Performance timeline behavior and focused 50,000-mark/missing-mark coverage on current |
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
A captured early
performance.markmethod and the currentperformance.measuremethod could observe different stores, causing a same-turn Code OSS User Timing failure.This change routes captured and current methods through one retained realm timeline, then hydrates the iframe before the focused Performance probe and waits for that realm deterministically. Coverage includes main/iframe method identity, bounded 50,000-mark behavior, and missing-mark regressions. The focused range is three directly related commits across seven files.
Closes #83. Equivalent commits are already in draft consolidation PR #76. This PR targets its recorded pre-fix review base for isolated validation and must remain open; do not merge it to
main.