Repository navigation
Isolate the NodeIterator stress fixture - #129
Merged
wieslawsoltes merged 1 commit intoSep 16, 2026
Merged
Conversation
wieslawsoltes
force-pushed
the
fix/node-iterator-stress-isolation
branch
from
September 16, 2026 10:05
f01b438 to
d20e6a9
Compare
wieslawsoltes
changed the base branch from
review/code-oss-node-iterator-stress-base
to
feature/node-iterator
September 16, 2026 10:20
wieslawsoltes
force-pushed
the
fix/node-iterator-stress-isolation
branch
from
September 16, 2026 20:16
d20e6a9 to
d84a6a6
Compare
wieslawsoltes
marked this pull request as ready for review
September 16, 2026 20:21
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
The 50,000-node NodeIterator gate shared a long-lived engine with the full suite and could abort under Windows PartitionAlloc during teardown.
This test-only layer runs the unchanged 50,001-visit assertions on a fresh engine, records native DOM, wrapper-handle, and V8 heap bounds before destruction, and destroys the fixture immediately after measurement. Production runtime and allocator behavior are unchanged.
Closes #85. The equivalent test change remains in draft consolidation PR #76.
Cumulative validation
a459e0fd; exact cumulative headd84a6a6fgit diff --checkNative GitHub stack #158
Merge both layers atomically through Stack #158 after the current-head related check passes.