Repository navigation
Implement NodeIterator for DOM traversal - #127
Merged
Merged
Conversation
wieslawsoltes
force-pushed
the
feature/node-iterator
branch
3 times, most recently
from
September 16, 2026 10:05
d20e6a9 to
881c8f6
Compare
wieslawsoltes
changed the base branch from
review/code-oss-node-iterator-base
to
main
September 16, 2026 10:20
wieslawsoltes
force-pushed
the
feature/node-iterator
branch
from
September 16, 2026 20:16
881c8f6 to
a459e0f
Compare
wieslawsoltes
marked this pull request as ready for review
September 16, 2026 20:21
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
DOMPurify captures
Document.prototype.createNodeIterator; its absence blocked unchanged Code OSS chat rendering.This change adds root-bounded document-order
NodeIteratortraversal, lazy filter and mask semantics, forward/backward state, mutation coverage, a DOMPurify-shaped native contract, an unchanged hash-pinned WPT, and a bounded 50,000-node linear performance gate.Closes #82. Equivalent runtime and test changes remain in draft consolidation PR #76.
Validation
mainat8baff8ae; exact heada459e0fdnode-iteratorcontract: 10/10 local passes; warm runs 48-51 msdom-treewalker-nodefilter-focus-navigationprofile: 1/1 document, 6/6 subtestsNodeIterator-removal-during-filteringWPT: 1/1 document, 4/4 subtestsgit diff --checkNative GitHub stack #158
Only the cumulative top PR receives remote validation. Merge both layers atomically through Stack #158 after the top related check passes.