Skip to content

kernel-trace-analysis: fix SKILL.md nits so the evals pass #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coderfeli merged 1 commit into from
Oct 25, 2026
Merged

kernel-trace-analysis: fix SKILL.md nits so the evals pass #1322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .claude/skills/kernel-trace-analysis/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ description: >
analyze the trace data using hotspot_analyzer.py to identify top-K stall hotspots
(VMEM-load, VMEM-wait, LDS/SMEM-wait, barrier, MFMA stalls) mapped back to source
lines, and produce an actionable optimization plan.
Also analyzes rocprofv3 PMC counter CSVs (L2 hit rate, partial reads, over-fetch).
Comment thread
coderfeli marked this conversation as resolved.
Usage: /kernel-trace-analysis <cmd>
Can also analyze an existing dispatch dir directly: /kernel-trace-analysis --dir <path>
allowed-tools: Read,Edit,Bash,Grep,Glob,Agent,Write
Expand All @@ -15,7 +16,8 @@ allowed-tools: Read,Edit,Bash,Grep,Glob,Agent,Write
Profile and analyze GPU kernel ATT traces to identify stall hotspots and produce
an optimization plan.

All analysis is done programmatically via `hotspot_analyzer.py` + `code.json`.
All analysis is done by running the bundled `hotspot_analyzer.py` (ATT) and
`pmc_l2_analyzer.py` (PMC CSVs); never recompute their metrics yourself.
Comment thread
coderfeli marked this conversation as resolved.
Do **not** use GUI tools.

> If the question is only "did my change increase register pressure, spills, or
Expand Down Expand Up @@ -57,8 +59,7 @@ If the user provides `--dir <path>` or already has a `ui_output_agent_*_dispatch

```bash
# Both analyzers ship with this skill -- do not reimplement them.
python ${CLAUDE_SKILL_DIR}/scripts/hotspot_analyzer.py <dispatch_dir> --topk 15 --mode both
python ${CLAUDE_SKILL_DIR}/scripts/hotspot_analyzer.py <dispatch_dir> --topk 5 --mode src --detail --context 4
python ${CLAUDE_SKILL_DIR}/scripts/hotspot_analyzer.py <dispatch_dir> --kernel <kernel> --topk 15 --mode both --detail --context 4
Comment thread
coderfeli marked this conversation as resolved.
```

Skip to **Step 5: Interpret Results**.
Expand Down Expand Up @@ -443,7 +444,7 @@ After running `hotspot_analyzer.py --detail`, produce a prioritized plan:
### #1 :LINE stall=XK (N%) VMEM-load stall_rate=92%
Root cause: buffer_load inside QK MFMA loop — only 1 MFMA of hiding time.
Fix: Move all V loads before the QK MFMA loop.
Estimated gain: ~20% kernel cycle reduction.
Estimated gain: ~20% kernel cycle reduction (hypothesis; verify correctness and re-time).
Comment thread
coderfeli marked this conversation as resolved.

### #2 :LINE stall=XK (N%) VMEM-load stall_rate=80%
Root cause: K loads sequential with no compute interleaved.
Expand Down
Loading