Repository navigation
kernel-trace-analysis: fix SKILL.md nits so the evals pass - #1322
Merged
coderfeli merged 1 commit intoOct 25, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
danielholanda
commented
Oct 23, 2026
danielholanda
commented
Oct 23, 2026
danielholanda
commented
Oct 23, 2026
danielholanda
commented
Oct 23, 2026
danielholanda
changed the title
kernel-trace-analysis: fix SKILL.md nits so the evals pass
coderfeli
approved these changes
Oct 25, 2026
johnl-amd
added a commit
to amd/skills
that referenced
this pull request
Oct 26, 2026
Picks up ROCm/FlyDSL#1322, which tells the skill to run the bundled pmc_l2_analyzer.py rather than recompute its metrics inline. That was the one behavioral expectation failing here (12/13); upstream scored 13/13 on three consecutive runs with the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few
SKILL.mdnits so the skill's own behavioral evals pass reliably. With these edits it scored 13/13 on three runs in a row (1, 2, 3).See code comments for details. Feel free to resolve them all (they are only comments)