Skip to content

Fix puppet-resource_api gem dependency #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexjfisher wants to merge 1 commit into
base: 8.x
Choose a base branch
from
Draft

Fix puppet-resource_api gem dependency #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ end

gem "openfact", *location_for(ENV['OPENFACT_LOCATION'] || [">= 5.0", "< 7"])
gem "semantic_puppet", *location_for(ENV['SEMANTIC_PUPPET_LOCATION'] || ["~> 1.0"])
gem "puppet-resource_api", *location_for(ENV['RESOURCE_API_LOCATION'] || ["~> 2.0"])
gem "puppet-resource_api", *location_for(ENV['RESOURCE_API_LOCATION'] || ['>= 1.9.2', '< 2.0'])

@alexjfisher alexjfisher Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmburgan Or should we also allow 2.x as a Gem dependency? Even though we ship the agent packages with 1.9.2. (2.0 technically only states support for Puppet 7 was dropped).

@nmburgan nmburgan Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check what, if any, testing we have. But given OV9 doesn’t have many core changes and nobody has complained, I’d guess 2.x is probably safe.

@alexjfisher alexjfisher Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is specifically a PR against the 8.x branch. I think main is fine, as there's no conflict there between its Gemspec and

openvox/packaging/configs/components/puppet-resource_api.json

Line 1 in e4c91ba

{"url":"https://github.com/openvoxproject/puppet-resource_api.git","ref":"v2.0.1"}

@nmburgan nmburgan Oct 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just mean that since we didn’t run into any problems with 2.x on OV9, we probably won’t run into any on OV8 either, I’d guess

# Need to update the openssl gem on MacOS to avoid SSL errors.
# https://www.rubyonmac.dev/certificate-verify-failed-unable-to-get-certificate-crl-openssl-ssl-sslerror
gem 'openssl', '~> 3' if RUBY_PLATFORM =~ /darwin/
Expand Down
2 changes: 1 addition & 1 deletion openvox.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency('locale', '~> 2.1')
spec.add_runtime_dependency('openfact', '>= 5.0', '< 7')
spec.add_runtime_dependency('ostruct', '>= 0.5.5', '< 0.7')
spec.add_runtime_dependency('puppet-resource_api', '~> 2.0')
spec.add_runtime_dependency('puppet-resource_api', '>= 1.9.2', '< 2.0')
spec.add_runtime_dependency('racc', '~> 1.5')
spec.add_runtime_dependency('scanf', '~> 1.0')
spec.add_runtime_dependency('semantic_puppet', '~> 1.0')
Expand Down
Loading