Repository navigation
Fix puppet-resource_api gem dependency - #733
Draft
alexjfisher wants to merge 1 commit into
Draft
alexjfisher wants to merge 1 commit into
alexjfisher wants to merge 1 commit into
Conversation
Openvox 8 is explicitly packaged with `puppet-resource_api` `1.9.2`. (See `packaging/configs/components/puppet-resource_api.json`) This conflicted with the declared dependency of the `openvox` gem, (that required at least version `2.x`)
alexjfisher
commented
Oct 15, 2026
| gem "openfact", *location_for(ENV['OPENFACT_LOCATION'] || [">= 5.0", "< 7"]) | ||
| gem "semantic_puppet", *location_for(ENV['SEMANTIC_PUPPET_LOCATION'] || ["~> 1.0"]) | ||
| gem "puppet-resource_api", *location_for(ENV['RESOURCE_API_LOCATION'] || ["~> 2.0"]) | ||
| gem "puppet-resource_api", *location_for(ENV['RESOURCE_API_LOCATION'] || ['>= 1.9.2', '< 2.0']) |
Contributor
Author
Member
There was a problem hiding this comment.
Need to check what, if any, testing we have. But given OV9 doesn’t have many core changes and nobody has complained, I’d guess 2.x is probably safe.
Contributor
Author
There was a problem hiding this comment.
This is specifically a PR against the 8.x branch. I think main is fine, as there's no conflict there between its Gemspec and
Member
There was a problem hiding this comment.
Yeah, I just mean that since we didn’t run into any problems with 2.x on OV9, we probably won’t run into any on OV8 either, I’d guess
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Openvox 8 is explicitly packaged with
puppet-resource_api1.9.2.(See
packaging/configs/components/puppet-resource_api.json)This conflicted with the declared dependency of the
openvoxgem, (thatrequired at least version
2.x)