Increase minimum allowed HPWH EF/UEF, take 2#2240
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates validation and documentation to lower the minimum allowed HPWH EF/UEF to accommodate ENERGY STAR/DOE Efficient New Home reference home cases.
Changes:
- Lowered the minimum allowed HPWH
EnergyFactor/UniformEnergyFactorfrom 2.0 to 1.45 in the Schematron validator. - Updated validation error message expectations and the failing test input value accordingly.
- Updated workflow input documentation and the changelog to reflect the new minimum.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/source/workflow_inputs.rst | Updates documented min EF/UEF constraint for HPWH inputs. |
| HPXMLtoOpenStudio/tests/test_validation.rb | Updates expected Schematron error message and test case value for new min EF/UEF. |
| HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.sch | Lowers the Schematron min EF/UEF requirement for HPWHs to 1.45 and documents rationale. |
| HPXMLtoOpenStudio/measure.xml | Updates measure version metadata/checksums to reflect modified resources/tests. |
| Changelog.md | Updates breaking-change note to the new minimum EF/UEF requirement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shorowit
marked this pull request as ready for review
July 17, 2026 02:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Follow-up to #2239. Now sets the minimum to 1.45, since some of the ENERGY STAR/DOE Efficient New Home reference homes end up with HPWHs with efficiencies as low as 1.49.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run