Skip to content

Increase minimum allowed HPWH EF/UEF, take 2#2240

Merged
shorowit merged 1 commit into
masterfrom
hpwh_min_ef_uef_take2
Jul 17, 2026
Merged

Increase minimum allowed HPWH EF/UEF, take 2#2240
shorowit merged 1 commit into
masterfrom
hpwh_min_ef_uef_take2

Conversation

@shorowit

Copy link
Copy Markdown
Contributor

Pull Request Description

Follow-up to #2239. Now sets the minimum to 1.45, since some of the ENERGY STAR/DOE Efficient New Home reference homes end up with HPWHs with efficiencies as low as 1.49.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.sch) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Updates validation and documentation to lower the minimum allowed HPWH EF/UEF to accommodate ENERGY STAR/DOE Efficient New Home reference home cases.

Changes:

  • Lowered the minimum allowed HPWH EnergyFactor/UniformEnergyFactor from 2.0 to 1.45 in the Schematron validator.
  • Updated validation error message expectations and the failing test input value accordingly.
  • Updated workflow input documentation and the changelog to reflect the new minimum.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/source/workflow_inputs.rst Updates documented min EF/UEF constraint for HPWH inputs.
HPXMLtoOpenStudio/tests/test_validation.rb Updates expected Schematron error message and test case value for new min EF/UEF.
HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.sch Lowers the Schematron min EF/UEF requirement for HPWHs to 1.45 and documents rationale.
HPXMLtoOpenStudio/measure.xml Updates measure version metadata/checksums to reflect modified resources/tests.
Changelog.md Updates breaking-change note to the new minimum EF/UEF requirement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread HPXMLtoOpenStudio/tests/test_validation.rb
@shorowit
shorowit marked this pull request as ready for review July 17, 2026 02:25
@shorowit
shorowit merged commit dbaddb5 into master Jul 17, 2026
8 checks passed
@shorowit
shorowit deleted the hpwh_min_ef_uef_take2 branch July 17, 2026 02:25
@github-project-automation github-project-automation Bot moved this from Triage to Done in OpenStudio-HPXML Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants