Analysis and implementation plan for repository issues#15
Merged
Conversation
Copilot created this pull request from a session on behalf of
NamecoinGithub
July 9, 2026 13:24
View session
NamecoinGithub
approved these changes
Jul 9, 2026
NamecoinGithub
marked this pull request as ready for review
July 9, 2026 13:36
There was a problem hiding this comment.
Pull request overview
This PR extends Nexus Core management to support an externally configured Core binary path (via settings and env overrides), improves the error surfaced when the Core binary is missing, and updates the Electron/build toolchain dependencies.
Changes:
- Add an
embeddedCoreBinaryPathsetting and expose it in the Core settings UI. - Introduce a
core-binary-statusIPC endpoint and use it to provide a more actionable “core not found” error. - Upgrade Electron and several build dependencies (webpack/babel-loader/electron-builder) with corresponding lockfile updates.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared/lib/settings/defaultSettings.ts | Adds embeddedCoreBinaryPath to the Settings type and defaults. |
| src/shared/lib/core.ts | Improves missing-core error by querying core-binary-status over IPC. |
| src/main/renderer.js | Adds a security TODO comment for future hardening of renderer preferences. |
| src/main/main.js | Registers new core-binary-status IPC handler. |
| src/main/keyboard.js | Adds a security TODO comment for future hardening of keyboard window isolation. |
| src/main/core.js | Implements configured Core binary path resolution + status reporting and refactors core process management around it. |
| src/App/Settings/Core/EmbeddedCoreSettings.tsx | Adds UI field for “Core Binary Path”. |
| package.json | Updates Electron and build tooling dependency versions. |
| package-lock.json | Lockfile changes reflecting the dependency updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+217
to
+218
| "electron": "43.1.0", | ||
| "electron-builder": "26.15.3", |
Comment on lines
+53
to
+55
| try { | ||
| fs.accessSync(coreBinaryPath, fs.constants.X_OK); | ||
| return { |
Comment on lines
150
to
155
| } else { | ||
| PID = ( | ||
| await exec('ps -o pid --no-headers -p 1 -C ${Nexus_Daemon}', [], { | ||
| await exec('ps -o pid --no-headers -p 1 -C ${Nexus_Daemon}', { | ||
| env: modEnv, | ||
| }) | ||
| ) |
| "csv-stringify": "^6.5.2", | ||
| "electron": "^26.6.10", | ||
| "electron-builder": "26.13.1", | ||
| "electron": "43.1.0", |
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by AI Agent