Add detail document and refresh branch with recent merges#18
Merged
NamecoinGithub merged 9 commits intoJul 9, 2026
Merged
Conversation
…debase-fix-bugs-implement-todo # Conflicts: # README.md # package-lock.json # package.json # src/App/Settings/Core/EmbeddedCoreSettings.tsx # src/keyboard/VirtualKeyboard.tsx # src/keyboard/preload.js # src/main/core.js # src/main/keyboard.js # src/main/main.js
Copilot created this pull request from a session on behalf of
NamecoinGithub
July 9, 2026 16:35
View session
NamecoinGithub
marked this pull request as ready for review
July 9, 2026 16:37
There was a problem hiding this comment.
Pull request overview
This PR refreshes the branch with recent merged work (PRs #15–#17) and adds a detail document while preserving and extending Core binary validation/process detection and Electron IPC hardening.
Changes:
- Added a detail document capturing scope, problem areas, and review focus for Core binary + IPC hardening.
- Hardened privileged Electron IPC handlers via input allowlists/type checks (dialogs, menus, app paths, proxy requests, updater flags, etc.).
- Refined Core binary path normalization and Core process lookup behavior; updated settings UI wiring for choosing a Core binary.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared/lib/appMenu.ts | Aligns menu role naming for the fullscreen toggle item. |
| src/main/main.js | Adds IPC input validation/sanitizers and allowlists for privileged main-process handlers. |
| src/main/core.js | Refactors Core binary path normalization/status reporting and tightens process detection logic (including safer Windows tasklist invocation). |
| src/App/Settings/Core/EmbeddedCoreSettings.tsx | Refactors the Core Binary Path UI to a dedicated field component and updates how the form field is set from the file picker. |
| README.md | Updates build prerequisites text to align Node/npm requirements and notes the Electron baseline. |
| package.json | Tightens the npm engines requirement to a concrete minimum version. |
| package-lock.json | Keeps lockfile engines metadata aligned with package.json. |
| docs/Detail_Document.md | Adds a detail-level document describing the combined scope and review focus areas. |
| configs/webpack.config.renderer.prod.babel.js | Adds the keyboard preload bundle entry to the renderer production build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+154
to
+160
| return filterList.map((filter) => ({ | ||
| name: ensureString(filter?.name, 'Dialog filter name'), | ||
| extensions: ensureStringArray( | ||
| filter?.extensions, | ||
| 'Dialog filter extensions' | ||
| ), | ||
| })); |
Comment on lines
+180
to
+184
| properties: (options.properties || []).filter((property) => | ||
| allowedOpenDialogProperties.has(property) | ||
| ), | ||
| filters: sanitizeDialogFilters(options.filters), | ||
| }; |
Comment on lines
376
to
378
| ipcMain.on('get-path', (event, name) => { | ||
| if (typeof name !== 'string' || !appPathNames.has(name)) { | ||
| log.warn('Rejected invalid get-path IPC request'); | ||
| event.returnValue = undefined; | ||
| return; | ||
| } | ||
| event.returnValue = app.getPath(name); | ||
| event.returnValue = app.getPath(sanitizeAppPathName(name)); | ||
| }); |
Comment on lines
+100
to
+113
| const pickCoreBinary = async () => { | ||
| const filePaths = await ipcRenderer.invoke('show-open-dialog', { | ||
| title: __('Select Nexus Core binary'), | ||
| properties: ['openFile'], | ||
| filters: | ||
| process.platform === 'win32' | ||
| ? [{ name: 'Windows executable', extensions: ['exe'] }] | ||
| : undefined, | ||
| }); | ||
| } catch (err: unknown) { | ||
| openErrorDialog({ | ||
| message: __('Failed to open file picker') + ': ' + getErrorMessage(err), | ||
| }); | ||
| return; | ||
| } | ||
|
|
||
| if (paths && paths[0]) { | ||
| updateSettings({ embeddedCoreBinaryPath: paths[0] }); | ||
| } | ||
| } | ||
| if (filePaths?.[0]) { | ||
| input.onChange(filePaths[0]); | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task required a detail document and an updated branch containing the recent merged work from PRs #15, #16, and #17. This PR keeps the combined scope in one branch while documenting and preserving the Core binary and Electron IPC hardening work.
Branch refresh
origin/Merginginto this branch.Detail document
docs/Detail_Document.md.Core and IPC follow-ups
Example of the safer Windows process lookup pattern: