test(webxr): enable warm-up simulation in StreamAttachTimeoutTest attempt 2

[gareth-morgan-nv]

Summary

StreamAttachTimeoutTest.spec.js fails on main: attempt 2 ("attaches fine, no frame ever") never turned on MockCloudXR's warm-up simulation, so the mock rendered normally and emitted streaming metrics for the whole attempt. The test's "no streaming metrics before warm-up completes" check counts any metric before a warm-up completed status as a failure, so it reported streamingMetricsFiredDuringWarmup=true.

Fix: give attempt 2 warmupTotalFrames: null. That turns the simulation on, so render() stays black like a stuck decoder and no metrics fire. No warm-up frame is ever fed, so the warm-up-begin timeout still triggers, which is what attempt 2 is meant to exercise.

Test-only change; no product code touched.

Why CI did not catch it

CI runs npm test (jest), which excludes tests/playwright/. The Playwright specs only run via npm run test:playwright, which no workflow calls.

Test plan

• npx playwright test tests/playwright/StreamAttachTimeoutTest.spec.js: failed before, passes 3/3 after (about 9 s each)
• eslint, prettier and SKIP=check-copyright-year pre-commit run --all-files clean
• Other Playwright specs not run

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Updated the streaming timeout test scenario to simulate a warm-up period without recording frame calls. The scenario also reflects the expected black render and absence of streaming metrics. These changes affect test coverage only; no user-facing behavior changes.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
• Review profile: CHILL
• Plan: Enterprise
• Run ID: f93d4c4d-69af-49be-9ff1-774330b796fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
• Review profile: CHILL
• Plan: Enterprise
• Run ID: dc56b89f-c883-4645-ac1f-04027fd7ccd3

📥 Commits

Reviewing files that changed from the base of the PR and between 63a6935 and 8d315da.

📒 Files selected for processing: 1

• deps/cloudxr/webxr_client/tests/mock/StreamAttachTimeoutTest.tsx

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📝 Walkthrough

Attempt 2 now sets warmupTotalFrames to null. Its comment describes warm-up simulation with no frames, a black render, and no streaming metrics.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 8d315

The updated test exercises the warm-up timeout and checks retries, metric suppression, and warm-up completion. No unresolved merge risk was identified.

Pre-merge checks: 5

Passed checks: 5 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: enabling warm-up simulation in attempt 2 of the WebXR stream attach timeout test.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}