Repository navigation
refactor: reorganize src/unilab by owner layer - #342
Merged
Merged
Conversation
structured_configs promoted to top-level unilab.structured_configs; reward helpers folded into unilab.training.reward. The two *_params modules held only unused KNOWN_TASKS stubs and are deleted. Eliminates the config/ vs conf/ naming collision at the source.
benchmark/ wasn't covered by the earlier refactor commits, so two scripts still pointed at unilab.config.structured_configs and unilab.base.dtype_config. Ruff flagged the resulting import blocks as unsorted because the phantom paths confused isort grouping. Also silence a pre-existing mypy no-redef on the try/except import fallback so the pre-commit hook passes.
TATP-233
force-pushed
the
split-utils-ownership
branch
from
April 24, 2026 17:31
9f691a4 to
b0a1473
Compare
TATP-233
added a commit
that referenced
this pull request
May 4, 2026
refactor: reorganize src/unilab by owner layer
TATP-233
added a commit
that referenced
this pull request
May 30, 2026
refactor: reorganize src/unilab by owner layer
TATP-233
added a commit
that referenced
this pull request
Sep 4, 2026
refactor: reorganize src/unilab by owner layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Structural cleanup of
src/unilab/so each package sits at its owner layer. Every commit targets one dependency arrow or misplaced module; together they remove the cross-layer back-edges that had accumulated.f83e8c9/8df738b— split sharedutils/into owner packages and drop the re-export shimse4a07f1— centralize rsl-rl training helpers57bfc25— move the shared buffer base out ofalgosintoipc(unblocks theipc → algosback-edge)aadc3f4— liftdtype_configto top-level;dr/no longer depends onbase/79a28c8— promote rich training loggers to a peerunilab.loggingpackage;algos/no longer imports fromtraining/303b34d— stop re-exportingrender_play_modefromtraining/; scripts import directly fromunilab.visualization02eddfd— retireunilab.config:structured_configs→ top-level,reward→training/reward.py, delete unusedKNOWN_TASKSstubsNet effect:
grep -rn "from unilab.base.dtype_config\|from unilab.training.logging\|from unilab.config" src/ scripts/ tests/is empty;algos/no longer imports fromtraining/;base/anddr/are independent.Test plan