Repository navigation
refactor: unify g1 walk env tasks - #322
Merged
Merged
Conversation
TATP-233
force-pushed
the
fix/issue-175-g1-single-env-class
branch
from
April 22, 2026 02:44
2318a5e to
7b1c8e1
Compare
- split_obs_dict / get_obs_dims: when no critic group, critic = obs
(never return None or 0)
- All learners (TD3/SAC/FlashSAC): critic_obs_dim is now a required
parameter, no default-0-then-fallback pattern
- update_critic / update_actor: use data["critic"] directly instead
of data.get("critic") with fallback to actor obs
- OffPolicyRunner: rename critic_dim → critic_obs_dim for consistency
- Collectors: critic_np is always a concrete array, no None branches
- FastTD3Runner: pass env_cfg_override to get_env_dims and
critic_obs_dim to learner (fixes td3/g1_walk_flat config load)
TATP-233
added a commit
that referenced
this pull request
May 4, 2026
refactor: unify g1 walk env tasks
TATP-233
added a commit
that referenced
this pull request
May 30, 2026
refactor: unify g1 walk env tasks
TATP-233
added a commit
that referenced
this pull request
Sep 4, 2026
refactor: unify g1 walk env tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175
Summary
G1WalkEnvclassg1_walk_xxxand update related tests, docs, and benchmarksValidation
ruff,ruff format,pyright,mypy)