Repository navigation
fix: remove async runner extra kwargs leakage - #311
Merged
Merged
Conversation
TATP-233
force-pushed
the
fix/issue-238-async-runner-runtime-context
branch
from
April 18, 2026 15:45
dc5825e to
a80ad4e
Compare
TATP-233
added a commit
that referenced
this pull request
May 4, 2026
…time-context fix: remove async runner extra kwargs leakage
TATP-233
added a commit
that referenced
this pull request
May 30, 2026
…time-context fix: remove async runner extra kwargs leakage
TATP-233
added a commit
that referenced
this pull request
Sep 4, 2026
…time-context fix: remove async runner extra kwargs leakage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncRunner.extra_kwargsand stop implicitly merging undeclared collector kwargssim_backendas explicit runner runtime identity and forward it directly from APPO/offpolicy runnersValidation
uv run pytest tests/ipc/test_async_runner.py tests/algos/test_offpolicy_runner_unit.py tests/algos/test_appo_runner_unit.py -quv run pytest tests/scripts/test_train_scripts.py -k "build_appo_runner_kwargs_forwards_sim_backend" -qImpact
Fixes #238