Repository navigation
feat(reset): publish call-graph diagnostics - #1942
Merged
TATP-233 merged 1 commit intoOct 2, 2026
Merged
Conversation
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#1874 has exhausted reset transport and tensor-expression micro-optimizations: #1913, #1914, #1940, UniSim #332, and #1941 were all neutral, while phase timings repeatedly reflected queued GPU drain rather than Python dispatch. Before implementing an owner-level fused reset transaction, the call graph itself must be measured rather than inferred from wall-time labels.
Change
Add stable selected-reset count diagnostics alongside existing timing keys:
reset_done_event_term_count— configured reset-mode event terms.reset_done_command_term_count— configured command terms.reset_done_manager_reset_count— Manager reset passes invoked (currently seven).reset_done_observation_term_count— observation terms declared across groups.reset_done_sampler_host_transfer_count— explicit sampler D2H transfers inTensorMotionCommandreset:Implementation:
backend_timing.py.ManagerBasedRlEnv.reset().CommandManager.reset_diagnostics()collection boundary.TensorMotionCommandresets its per-reset transfer counter before resampling and exposes the count through the command boundary.reset_done_count.No reset semantics, manager execution, term dispatch, RNG, observations, or backend APIs change.
Validation
UNILAB_LOCAL_UNISIM=... uv run pytest -q tests/base/test_torch_env.py tests/managers tests/envs/test_motion_command_partial_reset.py tests/envs/mdp/test_uniform_velocity_command.py— 137 passed.make check— passed (existingcli.pyDrake import warning only).Intended use
This is diagnostic-only and deliberately performance-neutral. The next 592 run can now report Manager dispatch counts per reset row, and the fused-reset contract can prove that a candidate removes Manager passes instead of merely shifting a timing boundary.