fix(appo): keep Motrix playback observations in tensors - #1731
Merged
TATP-233 merged 2 commits intoSep 29, 2026
Merged
Conversation
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewable outcome
The APPO/Motrix playback loop now keeps policy I/O on the strict TorchEnv tensor boundary:
env.deviceasint64tensors;float32Torch tensors and fail closed if a non-tensor reaches the reset or step boundary;env.deviceas contiguousfloat32and submitted toTorchEnv.step();TorchEnvStatewithout NumPy or a host roundtrip.Closes part of #1704.
Validation
UNILAB_LOCAL_UNISIM=/home/user/ws/unilabsim/unisim uv run pytest tests/scripts/test_train_scripts.py -q -k 'run_motrix_play_loop' --override-ini='markers=' -m ''— 1 passed.UNILAB_LOCAL_UNISIM=/home/user/ws/unilabsim/unisim make check— pass (mypy clean; one pre-existing unresolved optionaldrake_uni.runtimepyright warning).UNILAB_LOCAL_UNISIM=/home/user/ws/unilabsim/unisim make test-all— 1834 passed / 26 skipped, benchmark imports 35/35 and 36/36.tests/scripts/test_train_scripts.pyhas three pre-existing failures on the unchanged base (two off-policy video return assertions and oneplay_interactivephysics-state contract failure);make test-alldeselects that slow lane and the focused changed test passes.Notes for review
Independent of #1725–#1730 and based on current
develop/tensor-runtime.