bench(rl): keep active collector transitions in tensors - #1727
Merged
TATP-233 merged 5 commits intoSep 29, 2026
Merged
Conversation
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env.device.torch.from_numpytransition conversions.Part of #1704.
Stacked on #1726 (which is stacked on #1725). Merge in that order, or retarget after the preceding merges.
Validation
UNILAB_LOCAL_UNISIM=/home/user/ws/unilabsim/unisim uv run pytest -q tests/benchmark/test_offpolicy_collector_active_benchmark.py tests/benchmark/test_extract_offpolicy_metrics.py— 35 passedUNILAB_LOCAL_UNISIM=/home/user/ws/unilabsim/unisim uv run make checkUNILAB_LOCAL_UNISIM=/home/user/ws/unilabsim/unisim uv run make test-all— 1835 passed, 26 skipped; benchmark imports 35/35 and 36/36Remaining boundary
ReplayBufferis currently CPU-backed in this benchmark, matching its existing CPU ingress contract.uni_rlstill needs its tensor-first public env contract and single tensor collector path; that external package work remains tracked by #1704.