Repository navigation
Conversation
Collaborator
Author
|
Fixture provenance note: the committed explanatory-comment XML has SHA-256 |
TATP-233
marked this pull request as ready for review
September 28, 2026 16:13
TATP-233
deleted the
feat/issue-1682-isaacsim-material-sharing-fixture
branch
September 28, 2026 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnvCfg.isaacsim_share_friction_materialsand forwardsshare_friction_materialsonly when the task explicitly opts in.This is coordinated with unilabsim/unisim#320 and does not continue IsaacSim performance optimization.
Linked Work
develop/tensor-runtimedevelop/tensor-runtimeValidation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
make testfailures are confined to the pre-existing Drake/local-sibling dependency setup and do not touch IsaacSim files:A clean worktree of the unchanged base also fails
test_unisim_dependency_uses_an_approved_sourcebecause this local checkout resolvesunisim-coretofile:///home/user/ws/unilabsim/unisiminstead of the approved Git URL.make test-allremains a merge gate and must be rerun in the integration environment after the sibling checkout/version is synchronized.Remote CI route:
main: not scheduled; localmake test-allis the test gate (currently blocked by the unrelated local environment failures above).Impact
isaacsimArtifacts
m10-isaacsim-box025-shared-materials-angular-correct-direct-reset-g1-2048-5090-gpu7-20260928.jsonb986065843ded85571fa3c4f88d38e0aa541500ae6419b2bd3681533cd2d9971Checklist