Skip to content

refactor!: remove sharpa task and hora algorithm (migrate to sharpa_rl_unilab) - #1549

Merged
TATP-233 merged 1 commit into
mainfrom
dev/issue-1547-remove-sharpa-hora
Sep 9, 2026
Merged

refactor!: remove sharpa task and hora algorithm (migrate to sharpa_rl_unilab)#1549
TATP-233 merged 1 commit into
mainfrom
dev/issue-1547-remove-sharpa-hora

Conversation

@TATP-233

@TATP-233 TATP-233 commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

概要

将 sharpa_inhand 任务族(SharpaInhandRotation/Grasp)与全部 hora 算法集成(hora_ppo / hora_appo / hora_sac / hora_distill)从 UniLab 移除,迁移至独立插件仓库 unilabsim/sharpa_rl_unilab,模式参照 legged-manipulation_unilab(unilab.tasks entry point + 资产随 wheel 分发)。

Close 前需与 unilabsim/unilab_rl 的配套 PR 协调合并(见 #1547)。

改动

  • 删除 tasks/manipulation/sharpa_inhand/assets/robots/sharpa_wave/conf/{ppo,appo,sac}/task/sharpa_inhand*/conf/hora_distill/scripts/play_hora_appo.pytraining/hora_distill_config.pyscripts/train_hora_distill.py 等专属代码(38 个文件)
  • 清理 94 个文件中的 sharpa/hora 引用:interactive_playback hora 分支、train_offpolicy 特判、demo、cli、hub 注册行、benchmark/support-matrix、共享测试数据行、中英文档
  • 保留通用机制:asset hub、runtime_resolver 分发、adapt_legacy_factory、migration/support matrix 工具链

验证

  • make check 绿(ruff/pyright 0 errors)
  • 受影响 pytest:1001 passed, 19 skipped, 1 xfailed
  • slow 的 env/train-script config 组合:49 passed, 2 skipped
  • Sphinx 全新构建零 WARNING/ERROR
  • 全仓 rg -i 'sharpa|hora' 零命中(排除 .git/.venv/lock/log)

待办(合并前)

Issue: #1547

Migrate the sharpa_inhand task family (SharpaInhandRotation/Grasp) and all
hora algorithm integration (hora_ppo/hora_appo/hora_sac/hora_distill) to the
dedicated unilabsim/sharpa_rl_unilab repository, following the
legged-manipulation_unilab plugin-package pattern (unilab.tasks entry
point, bundled assets).

Generic mechanisms are kept: asset hub, runtime_resolver dispatch,
adapt_legacy_factory, migration/support matrix tooling.

Issue: #1547
@TATP-233
TATP-233 merged commit 8f34d4b into main Sep 9, 2026
8 checks passed
@TATP-233
TATP-233 deleted the dev/issue-1547-remove-sharpa-hora branch September 9, 2026 11:21
TATP-233 added a commit that referenced this pull request Sep 9, 2026
…branch

Accept the upstream deletion of scripts/train_hora_distill.py and
src/unilab/scripts/play_hora_appo.py (PR #1549 moved hora to
unilabsim/sharpa_rl_unilab); the CameraCfg/overlay edits on those files
are superseded by the move and will be re-applied in the new repo.
Drop the hora camera test appended by this branch and the ADR-0008
evidence entry for play_hora_appo.py.

Refs unilabsim/wuji_unilab#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant