fix: resolve high-severity npm advisories blocking CI - #698
Merged
rdmueller merged 1 commit intoJul 24, 2026
Conversation
`npm audit --audit-level=high` started failing on every PR after new advisories were published against dependency versions that had not changed; main's last green run predates them. Confirmed identical on a clean checkout of main, so this is not caused by any open PR. `npm audit fix` (no --force) resolves 4 of 6 within existing semver ranges — package-lock.json only, package.json untouched: - postcss 8.5.14 → 8.5.23 (high — path traversal, GHSA-r28c-9q8g-f849) - brace-expansion 5.0.6 → 5.0.8 (high — ReDoS, GHSA-3jxr-9vmj-r5cp) - echarts 6.0.0 → 6.1.0 (moderate — XSS, GHSA-fgmj-fm8m-jvvx) - body-parser 1.20.5 → 1.20.6 (low — DoS, GHSA-v422-hmwv-36x6) The 2 remaining are moderate `uuid` advisories reached through @lhci/cli (dev-only Lighthouse tooling); clearing them needs a breaking downgrade to @lhci/cli@0.6.1, and moderate does not trip the --audit-level=high gate. Also untrack playwright-report/ and test-results/, which every `npm run test:e2e` rewrites — they made the working tree dirty and blocked branch switches mid-test. Verified: lint clean, 121/121 unit, 38/38 E2E, build green with the bumped echarts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
WalkthroughDie Website-Gitignore-Datei ignoriert künftig die von Playwright erzeugten Verzeichnisse ChangesPlaywright-Artefakte
Estimated code review effort: 1 (Trivial) | ~2 Minuten 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Dependency Security Auditjob (npm audit --audit-level=high) fails on every PR right now, including pure documentation changes. It is not caused by any of them: new advisories were published against dependency versions that have not changed, and main's last green run is 6 days old.Confirmed by running the audit on a clean checkout of
main— the same 6 vulnerabilities, byte for byte:Fix
npm audit fix(no--force) resolves 4 of 6 within existing semver ranges.package-lock.jsononly —package.jsonis untouched.echarts is the only runtime dependency in that list, so it got the most attention below.
What is left, deliberately
Two moderate
uuidadvisories reached through@lhci/cli(dev-only Lighthouse tooling). Clearing them requiresnpm audit fix --force, which downgrades to@lhci/cli@0.6.1— a breaking change to the Lighthouse job for a moderate issue in a tool that never runs in production. Moderate does not trip the--audit-level=highgate, so CI goes green without it.Also: untrack Playwright run artifacts
website/playwright-report/index.htmlandwebsite/test-results/.last-run.jsonare tracked, and everynpm run test:e2erewrites them. They dirty the working tree and block branch switches mid-test. Added to.gitignoreand removed from the index — this is the same "no build artifacts in commits" rule #695 added to the reviewer checklist.Verification
npm audit --audit-level=high→ passesnpm run lint→ cleannpm test→ 121/121npm run test:e2e→ 38/38 (run twice; an earlier run showed 3 failures in the card-grid modal specs, which reproduce on unmodifiedmainunder concurrent load and pass in isolation — flakiness, not the echarts bump)npm run build→ green🤖 Generated with Claude Code
Summary by CodeRabbit