fix: render the German Contributing page from the maintained source - #697
Conversation
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
WalkthroughDie deutsche CONTRIBUTING-Dokumentation wird künftig aus ChangesCONTRIBUTING-Dokumentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The failing New advisories were published against dependency versions that have not changed. Running the same command on a clean checkout of Main's last green run is 6 days old, which is why nobody has seen it yet. Every PR opened from now on hits it. #698 fixes it — |
The /de/contributing page was built from website/public/CONTRIBUTING.de.adoc, while every contributor edit since LLM-Coding#603 went into docs/CONTRIBUTING.de.adoc — the file next to its English sibling. Nothing rendered that file, so German readers never saw the artifact taxonomy (LLM-Coding#585), the Viability Test (LLM-Coding#640), the ADR-008 topic-neutral gate, the issue-title convention (LLM-Coding#564), or the developer setup, PR review policy and Criticism/Current-Status rules from LLM-Coding#695. - render-docs.js renders docs/CONTRIBUTING.de.adoc; the stale public/ copy is deleted, leaving one German source - rewrite five relative link: targets in both Contributing files (ADR-007, ADR-008, docs/roles/) that resolved against the served route and 404'd - gitignore the generated CONTRIBUTING*.toc.html build artifacts Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
9ae136a to
4aa06f3
Compare
Problem
The German Contributing page at
/de/contributingis rendered fromwebsite/public/CONTRIBUTING.de.adoc. That file has not been touched since #603. Every contributor edit since then went intodocs/CONTRIBUTING.de.adoc— the file that sits next to its English sibling and looks like the maintained one. Nothing rendered it.Verified on the live site —
https://llm-coding.github.io/Semantic-Anchors/de/contributingis missing:German contributors have been reading the state of #603 for months.
Fix
scripts/render-docs.jsrendersdocs/CONTRIBUTING.de.adocinstead of the copy underwebsite/public/website/public/CONTRIBUTING.de.adocis deleted — one German source againlink:targets in both Contributing files (ADR-007, ADR-008,docs/roles/) resolved against the served route and 404'd on the website; they now use absolute GitHub URLs, which work on the site and in GitHub's rendered view.gitignorecovers the generatedCONTRIBUTING*.toc.htmlbuild artifacts, which were showing up as untrackedThe client only ever fetches the rendered
.html(doc-page.js:43), never the.adoc, so removing the public source is safe. The output pathwebsite/public/CONTRIBUTING.de.htmlis unchanged.Verification
npm run build→✓ pre-rendered /contributing (+ /de variant). The prerendereddist/de/contributing/index.htmlnow carries all sections, and both ADR links resolve:npm run lintclean,npm test121/121 passing.Note for #641
@JensGrote — #641 adds a German Viability-Test section to
website/public/CONTRIBUTING.de.adoc, the file this PR deletes.docs/CONTRIBUTING.de.adocalready carries that section from #640, so once this merges that part of #641 is redundant. Therejected-proposalschanges in #641 are unaffected. See my review there for the separate dead-link issue.🤖 Generated with Claude Code
Summary by CodeRabbit
Fehlerbehebungen
Dokumentation
Wartung