Skip to content

Derive size(::RegularChunks, d) from size #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meggart merged 1 commit into from
Oct 7, 2026
Merged

Derive size(::RegularChunks, d) from size #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/chunks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,7 @@ Base.@propagate_inbounds function Base.getindex(r::RegularChunks, i::Int)
@boundscheck checkbounds(r, i)
return max((i - 1) * r.chunksize + 1 - r.offset, 1):min(i * r.chunksize - r.offset, r.arraysize)
end
Base.size(r::RegularChunks, _) = div(r.arraysize + r.offset - 1, r.chunksize) + 1
Base.size(r::RegularChunks) = (size(r, 1),)
Base.size(r::RegularChunks) = (div(r.arraysize + r.offset - 1, r.chunksize) + 1,)
function Base.:(==)(r1::RegularChunks, r2::RegularChunks)
# The axis sizes must always match
r1.arraysize == r2.arraysize || return false
Expand Down
1 change: 1 addition & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ end
@test a1[3] == 9:10
@test length(a1) == 3
@test size(a1) == (3,)
@test size(a1, 2) == 1
@test subsetchunks(a1, 1:10) === a1
@test subsetchunks(a1, 4:9) === RegularChunks(5, 0, 6)
@test subsetchunks(a1, Int[]) === RegularChunks(1, 0, 0)
Expand Down
Loading