Repository navigation
Derive size(::RegularChunks, d) from size - #334
Merged
Merged
Conversation
The two-argument method ignored `d`, so `size(r, 2)` returned the number of chunks rather than 1. Its untyped `d` also made it a candidate for any `size(::AbstractVecOrMat, ::Int)` call that is not fully inferred, invalidating such compiled code when DiskArrays loads.
meggart
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two-argument method ignored
d, sosize(r, 2)returned the number of chunks rather than 1. Its untypeddalso made it a candidate for anysize(::AbstractVecOrMat, ::Int)call that is not fully inferred, invalidating such compiled code when DiskArrays loads.