Skip to content

Enhance AbstractNumberGenerator docblock with implementation requirements #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielsdrost7 merged 3 commits into from
Dec 30, 2025
Merged

Enhance AbstractNumberGenerator docblock with implementation requirements #296

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
536c050
Initial plan
Copilot Dec 30, 2025
18e458d
Improve AbstractNumberGenerator docblock with foundation details and …
Copilot Dec 30, 2025
6eccc9a
Use consistent PascalCase examples in type identifier documentation
Copilot Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Modules/Core/Support/NumberGenerator/AbstractNumberGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
* AbstractNumberGenerator.
*
* Base class for generating sequential numbers with customizable formatting.
* This is the foundation for all number generators in the system, including
* invoices, quotes, expenses, projects, tasks, payments, and customers.
*
* Child classes must define:
* - `$type` (required): The entity type identifier (e.g., 'Invoice', 'Quote', 'Project')
* - `$groupName` (optional): Default numbering scheme name (e.g., 'Default Invoice Numbering')
*
* Features:
* - Automatic number generation with configurable padding (e.g., PRJ-0001, PRJ-0023)
Expand Down