Skip to content

Enhance AbstractNumberGenerator docblock with implementation requirements#296

Merged
nielsdrost7 merged 3 commits into
developfrom
copilot/sub-pr-282
Dec 30, 2025
Merged

Enhance AbstractNumberGenerator docblock with implementation requirements#296
nielsdrost7 merged 3 commits into
developfrom
copilot/sub-pr-282

Conversation

Copilot AI commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

Improved documentation for AbstractNumberGenerator to clarify its role as the base class for all number generators and document required child class properties.

Changes

  • Foundation context: Added explanation that this is the base for all number generators (invoices, quotes, expenses, projects, tasks, payments, customers)
  • Implementation requirements: Documented that child classes must define:
    • $type (required): Entity type identifier (e.g., 'Invoice', 'Quote', 'Project')
    • $groupName (optional): Default numbering scheme name (e.g., 'Default Invoice Numbering')

Example child class:

class InvoiceNumberGenerator extends AbstractNumberGenerator
{
    protected string $type = 'Invoice';
    protected ?string $groupName = 'Default Invoice Numbering';
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai

coderabbitai Bot commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI and others added 2 commits December 30, 2025 09:42
…child class requirements

Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback from review on PR #282 Enhance AbstractNumberGenerator docblock with implementation requirements Dec 30, 2025
Copilot AI requested a review from nielsdrost7 December 30, 2025 09:45
@nielsdrost7
nielsdrost7 marked this pull request as ready for review December 30, 2025 09:50
@nielsdrost7
nielsdrost7 merged commit 9d63671 into develop Dec 30, 2025
1 check passed
@nielsdrost7
nielsdrost7 deleted the copilot/sub-pr-282 branch December 30, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants