Skip to content

preserve set link target #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pkliesch merged 1 commit into from
Aug 6, 2026
Merged

preserve set link target #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/ckeditor5-coremedia-link/src/linktarget/LinkTargetModelView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { reportInitEnd, reportInitStart } from "@coremedia/ckeditor5-core-common";
import { getLinkAttributes, LinkAttributes } from "@coremedia/ckeditor5-link-common";
import type {
DifferItemAttribute,
ModelRange,
ModelWriter,
DifferItem,
DifferItemAttribute,
DifferItemInsert,
ModelElement,
ModelNode,
ModelRange,
ModelWriter,
} from "ckeditor5";
import { Plugin } from "ckeditor5";
import { LINK_TARGET_MODEL, LINK_TARGET_VIEW } from "./Constants";
Expand Down Expand Up @@ -129,7 +129,10 @@ export default class LinkTargetModelView extends Plugin {
* @param diffItem - the variable to check
*/
#isDiffItemInsert(diffItem: DifferItem): diffItem is DifferItemInsert {
return diffItem.type === "insert" && diffItem.attributes.has("linkHref");
// an already set `linkTarget` (e.g., from paste) wins over the default.
return (
diffItem.type === "insert" && diffItem.attributes.has("linkHref") && !diffItem.attributes.has(LINK_TARGET_MODEL)
);
}

/**
Expand Down Expand Up @@ -187,6 +190,9 @@ export default class LinkTargetModelView extends Plugin {
* @private
*/
#computeLinkTargetForNode(child: ModelNode): string | undefined {
if (child.hasAttribute(LINK_TARGET_MODEL)) {
return undefined;
}
const url = child.getAttribute("linkHref");
if (url && typeof url === "string") {
return computeDefaultLinkTargetForUrl(url, this.editor.config);
Expand Down
Loading