Skip to content

Fix benchmark to correctly report metrics to Cosmos #49406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FabianMeiswinkel wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix benchmark to correctly report metrics to Cosmos #49406

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dabea44
Update CosmosMetricsReporter.java
FabianMeiswinkel Jun 4, 2026
7890a2a
Update CosmosMetricsReporter.java
FabianMeiswinkel Jun 5, 2026
02cfb46
Revert "Update CosmosMetricsReporter.java"
FabianMeiswinkel Jun 5, 2026
692529a
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…
FabianMeiswinkel Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ...zure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/CosmosMetricsReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;

/**
* Uploads all Micrometer metrics with full tag dimensions to a Cosmos DB container.
Expand Down Expand Up @@ -82,6 +83,7 @@ public class CosmosMetricsReporter {
private final CpuMemoryReader cpuReader;
private final ScheduledExecutorService scheduler;
private final boolean enabled;
private final AtomicBoolean isStopped;

private CosmosMetricsReporter(
MeterRegistry micrometerRegistry,
Expand All @@ -95,6 +97,7 @@ private CosmosMetricsReporter(
this.commitId = reporterConfig.getCommitId();
this.concurrency = concurrency;
this.cpuReader = new CpuMemoryReader();
this.isStopped = new AtomicBoolean(false);

this.micrometerRegistry = micrometerRegistry;
this.cosmosClient = new CosmosClientBuilder()
Expand Down Expand Up @@ -128,8 +131,12 @@ public void start(long interval, TimeUnit unit) {
}

public void report() {
if (!enabled) return;
if (!enabled || isStopped.get()) return;

reportCore();
}

private void reportCore() {
String timestamp = TIMESTAMP_FORMATTER.format(Instant.now());
double cpuPercent = round(cpuReader.getSystemWideCpuUsage() * 100);

Comment on lines 140 to 142
Expand All @@ -153,7 +160,9 @@ public void report() {
}

public void stop() {
if (!enabled) return;
if (!enabled || !isStopped.compareAndSet(false, true)) return;

reportCore();

scheduler.shutdown();
try {
Expand All @@ -162,8 +171,6 @@ public void stop() {
Thread.currentThread().interrupt();
}

report();

if (cosmosClient != null) {
cosmosClient.close();
}
Expand Down