Fix benchmark to correctly report metrics to Cosmos#49406
Open
FabianMeiswinkel wants to merge 4 commits into
Open
Fix benchmark to correctly report metrics to Cosmos#49406FabianMeiswinkel wants to merge 4 commits into
FabianMeiswinkel wants to merge 4 commits into
Conversation
…to users/fabianm/gw20bench
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Cosmos benchmark Micrometer reporter lifecycle to avoid reporting after shutdown and to ensure a final “flush” of metrics occurs reliably when stopping the benchmark run.
Changes:
- Added an
AtomicBooleanstop flag to prevent scheduledreport()calls afterstop()begins and to makestop()idempotent. - Extracted the upload loop into
reportCore()so it can be invoked both on the schedule and during shutdown.
Show a summary per file
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/CosmosMetricsReporter.java | Adds stop-guarding and refactors reporting into reportCore() to support a final flush on stop. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
140
to
142
| String timestamp = TIMESTAMP_FORMATTER.format(Instant.now()); | ||
| double cpuPercent = round(cpuReader.getSystemWideCpuUsage() * 100); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.