Fix strcat() buffer over-read in ConvertNumRadix#1263
Closed
x2658y wants to merge 1 commit into
Closed
Conversation
Keep the last byte of the local buffer reserved as the null terminator so strcat() never reads beyond array bounds.
zufuliu
pushed a commit
that referenced
this pull request
Jul 1, 2026
Keep the last byte of the local buffer reserved as the null terminator so strcat() never reads beyond array bounds.
Owner
|
Committed as f28a4ac, also increased buffer size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the last byte of the local buffer reserved as the null terminator so strcat() never reads beyond array bounds.