MaxMind GeoLite/GeoIP README Improvements#41
Conversation
|
@zakird Thoughts on my first point about the mode flag, do we need to keep this? |
|
@phillip-stephens I don't fully know why we'd get rid of it given that we have it? Is it causing harm? |
…ate into phillip/geolite2-data-access
zakird
left a comment
zakird
left a comment
There was a problem hiding this comment.
It looks like both GeoIP and GeoLite still exist; GeoLite is the free version of their commercial GeoIP product. We probably do still want to support both and I suspect may want to label this as MaxMind GeoIP but then support whatever fields we have available to us. It's probably also worth calling out that it looks like MaxMind has both a local downloadable database and a real-time API lookup. (i.e., we shouldn't change the name to be specific to the lite version, but we should denote it's a local module versus an API lookup module).
phillip-stephens
changed the title
|
@zakird Fair points, I've added verbiage to explain the various MaxMind offerings and reverted the rename to |
2 participants
Changes
Verified that with current data downloads, this module is still working.