chore(CI): move the node workflows to 22 - #2212
Merged
Merged
Conversation
Node 20 reached end of life in April. It still works today only because `node-version: '20'` resolves to 20.20.2 and @redocly/cli allows `>=20.19.0 <21.0.0` — a narrow arm that the next redocly is free to drop, at which point a routine dependabot bump goes red for a reason that is not about the bump. All three workflows that run node move together: `spec-validation` and `docs` are checks, and `gh-pages` is the deploy they are supposed to agree with. Verified locally on 22.23.2 — redocly lints identically (79 warnings, 181 ignored) and `docs:build` is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Node 20 reached end of life in April. The workflows still pass today only because
node-version: '20'resolves to 20.20.2, and@redocly/cliaccepts>=22.12.0 || >=20.19.0 <21.0.0— 20.20.2 clears that second arm by a single minor.That arm is the part worth removing. Whenever a future
@redocly/clidrops it, the breakarrives as a red
spec-validationon whatever dependabot bump happens to be open, pointingat the bump rather than at the runtime — the same misdirection #2210 fixed for the docs
build, where a dead link surfaced against a manual dispatch instead of the commit that
introduced it.
Changes
All three workflows that run node move together —
spec-validationanddocsare checks,gh-pagesis the deploy they exist to agree with. Leaving the deploy behind would reopen thecheck/deploy split #2210 closed.
.github/workflows/spec-validation.yml—node-version: '20'→'22'.github/workflows/docs.yml— same.github/workflows/gh-pages.yml— sameVerification
Run locally against Node 22.23.2, which is what
node-version: '22'resolves to today:composer redoclycomposer docs:builddocs:genThe redocly output is identical line for line to the same lint on Node 20, so no rule
changes behaviour across the bump.
vitepress@1.6.4declares noenginesconstraint at all.