Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The library required
symfony/console^7.4, even though only the CLI (bin/openapi) uses it. This locked out Symfony 6.4 LTS users, who are on a supported release, not an outdated one. It also blocked fixes like the schemaexamplesarray fix, which only landed in Console 6.8.1.Solution
This PR lowers the
symfony/consoleconstraint and rewritesGenerateCommandandGenerateInputto useconfigure()andInputInterfaceinstead of the#[MapInput],#[Argument], and#[Option]attributes, which required Console 7.3+. This keeps one code path for the CLI while letting library consumers depend on older, still-supported Console versions.Refs #2180