Repository navigation
Highlight component tags distinctly from HTML elements - #55
Merged
MrSubidubi merged 4 commits intoOct 16, 2026
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @eremannisto on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
requested changes
Sep 14, 2026
MrSubidubi
left a comment
MrSubidubi
left a comment
Contributor
There was a problem hiding this comment.
Can we combine this into one capture, please? Also, please revert the version bump
Contributor
Author
|
Hey, I added the changes, do they align what you were thinking? 😊 |
MrSubidubi
approved these changes
Oct 16, 2026
MrSubidubi
left a comment
MrSubidubi
left a comment
Contributor
There was a problem hiding this comment.
Yes, very much what I was referring to. Thank you!
Contributor
|
And congrats on your first contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the single
(tag_name) @tagrule so capitalized component tags map to@tag.component, while lowercase HTML elements stay@tag. Themes without atag.componentkey fall back totag, so this is non-breaking.Fixes the inconsistency where
.astrocolors components and HTML elements identically, while.tsxdistinguishes them.Tested locally as a dev extension and components render distinctly from HTML elements (screenshot below).
This closes #45