fix(ui): YPE-3871 - secondary buttons no longer read as disabled - #318
Merged
Conversation
The `secondary` variant paired `bg-muted` with `text-muted-foreground`, so active secondary buttons read as disabled controls. In the light theme the label sat at 5.6:1 against the button surface instead of 17.1:1. The BibleCard version picker button is where this was most visible, since it is the one secondary button consumers surface prominently. The dark theme hid the problem because `muted-foreground` there is near-white. Also drops the muted class from the BibleCard version picker's loading spinner so it inherits the button label color. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Both pages let their card stretch to the full viewport width, which is not how consumers embed these components. Cap them at `max-w-screen-sm` and center them so the demos show a realistic container. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 1d59ea7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cameronapak
changed the title
cameronapak
commented
Aug 4, 2026
Review feedback: the guard is unnecessary. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
bmanquen
approved these changes
Aug 4, 2026
cameronapak
deleted the
ype-3871-react-sdk-biblecard-version-button-label-uses-muted-text-color-and-reads-as-disabled
branch
August 4, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix.ui._.YPE-3871.-.secondary.buttons.no.longer.read.as.disabled.mp4
Summary
Secondary buttons paired
bg-mutedwithtext-muted-foreground, so active controls like the BibleCard version picker read as disabled. The variant now uses the normal foreground color, taking the light-theme label from 5.6:1 to 17.1:1 against the button surface.YPE-3871 - https://lifechurch.atlassian.net/browse/YPE-3871
Changes
bg-mutedwith the normal foreground color instead of the muted one.Start here: change 1 — it repaints every secondary button, not just BibleCard's.
Test plan
pnpm typecheck— passedpnpm lint— passedpnpm --filter @youversion/platform-react-ui test— 401 passedpnpm --filter @youversion/platform-react-hooks test— 289 passed@youversion/platform-coretests not run:.env.localis absent locally, and no core files changedmuted-foregroundis near-white, so it hid this bug, and the Expo SDK lives in another repo.