fix(ui): YPE-3868 - remove divider lines between books in the chapter picker - #317
Merged
Conversation
The book list now renders as a clean, undivided list to match the approved design. Row padding and tap targets are unchanged. YPE-3868 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 76ec094 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cameronapak
changed the title
cameronapak
commented
Aug 4, 2026
Addresses review feedback: the assertion restated the className and carried no value. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
cameronapak
changed the title
bmanquen
approved these changes
Aug 4, 2026
cameronapak
deleted the
ype-3868-react-sdk-remove-chapter-picker-book-list-shows-divider-lines-between-books-to-match-newer-designs
branch
August 4, 2026 20:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built-in.Retina.Display.Area.2026-08-04.02_45.PM.mp4
Summary
Book rows in
BibleChapterPickerno longer render separator lines, matching the approved design. The same component renders inside the RN Expo SDK's WebView, so both surfaces pick this up.Changes
@youversion/platform-react-ui.Start here: change 1 — the border is dropped by passing
yv:border-b-0, which tailwind-merge collapses against theAccordionItemprimitive's defaultyv:border-b. The shared primitive is untouched, so future consumers keep the standard border.Test plan
pnpm typecheck— passed (6/6 tasks, includes full build)pnpm lint— passed (7/7 tasks)pnpm --filter @youversion/platform-react-ui test— 401 passed / 30 filespnpm --filter @youversion/platform-react-hooks test— 289 passed / 29 files.yv\:border-b-0{border-bottom-width:0}AccordionTrigger'syv:py-4and is untouched, so tap targets are unchangedNeeds manual check: side-by-side against the Figma design, which is acceptance criterion 2 on YPE-3868.
Greptile Summary
The PR removes separator lines from book rows in
BibleChapterPickerwhile leaving the shared accordion primitive unchanged.yv:border-b-0.@youversion/platform-react-ui.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
yv:border-b-0override, matching the intended picker-specific design.Reviews (2): Last reviewed commit: "test(ui): drop chapter picker book list ..." | Re-trigger Greptile
Context used: