Repository navigation
spec: Recursion - #943
spec: Recursion#943
Conversation
Kimi Code ReviewAutomated review by Kimi (Moonshot AI) |
Codex Code Review
|
cdesaintguilhem
left a comment
There was a problem hiding this comment.
Mostly minor comments!
ff44161 to
f92d469
Compare
RobinJadoul
left a comment
There was a problem hiding this comment.
I'm wondering whether we should choose for the
82dcc54 to
a75546f
Compare
RobinJadoul
left a comment
There was a problem hiding this comment.
Not paying attention to all possible typography yet, trying to get the last high-level stuff out of the way
I'll try to do another pass later this week, but this is a first go at it
RobinJadoul
left a comment
There was a problem hiding this comment.
A couple minor things, but looking better and better.
Probably good to have another review pass by @cdesaintguilhem around this point, too.
| &= product(verify^*_0, verify^*_1)([comm(x), comm(y)], [[proof, b], r]),\ | ||
| $ | ||
| when | ||
| $r = d_(verify^*) ([comm(x), comm(y([comm(x), comm(y)], dot))], [proof, b])$. |
There was a problem hiding this comment.
This would need to define
There was a problem hiding this comment.
We might even make the definition of a split into a triple (v_0, v_1, d_v).
This gets rid of the existential quantifier, and makes it explicit where everything comes from when we get to here
There was a problem hiding this comment.
As discussed, there's indeed a subtlety about non-generator records.
We probably need to split up the arrows so that we get
- completeness:
$v(x) = 1 \implies v_0(x, d(x)) = 1 \wedge v_1(x, d(x)) = 1$ - soundness:
$\forall r. v_0(x, r) = 1 \wedge v_1(x, r) = 1 \implies v(x) = 1$
707a137 to
c33f0ff
Compare
cdesaintguilhem
left a comment
There was a problem hiding this comment.
I've read until, but not including, "34.4 Split-recursion". See typos and aesthetic remark in comments, otherwise everything reads very nicely up until then!
cdesaintguilhem
left a comment
There was a problem hiding this comment.
Some more nits and notation comments, but otherwise looks good to me.
Kimi Code ReviewAutomated review by Kimi (Moonshot AI) |
Co-authored-by: Erik <159244975+erik-3milabs@users.noreply.github.com>
Co-authored-by: Robin Jadoul <robin.jadoul@gmail.com>
Co-authored-by: Erik <159244975+erik-3milabs@users.noreply.github.com>
Co-authored-by: Robin Jadoul <robin.jadoul@gmail.com>
Co-authored-by: Cyprien de Saint Guilhem <c.desaintguilhem@gmail.com>
Co-authored-by: Cyprien de Saint Guilhem <c.desaintguilhem@gmail.com>
Co-authored-by: Robin Jadoul <robin.jadoul@gmail.com> Co-authored-by: Erik <159244975+erik-3milabs@users.noreply.github.com>
ab36e97 to
6377fd5
Compare
No description provided.