Added STANDARD topic retry policy#646
Open
alex268 wants to merge 1 commit intoydb-platform:masterfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
============================================
- Coverage 70.98% 70.93% -0.06%
Complexity 3348 3348
============================================
Files 379 379
Lines 15856 15862 +6
Branches 1663 1664 +1
============================================
- Hits 11255 11251 -4
- Misses 3953 3960 +7
- Partials 648 651 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![robot-vibe-db[bot]](https://avatars.githubusercontent.com/in/3319454?s=60&v=4){kind=small}
There was a problem hiding this comment.
AI Review Summary
Verdict: ✅ No critical issues found
Critical issues
No critical issues found.
Other findings
- Nit | Low: Method
ensureClosed()reads as "ensure the writer is closed" but actually throws when the writer IS closed. A name likeensureNotClosed()orthrowIfClosed()would better convey intent. —WriterImpl.java:88 - Nit | Low: Double blank line before constructor. —
TopicRetryConfig.java:63-64
This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.
pnv1
reviewed
Apr 30, 2026
| * Retry transient stream disconnections indefinitely with exponential backoff, | ||
| * but treat permanent errors as terminal. | ||
| */ | ||
| public static final RetryConfig STANDARD = st -> NON_RETRYABLE.contains(st.getCode()) ? null : DEFAULT_BACKOFF; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.