Skip to content

Fix test paths with spaces #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BoldNewMedia wants to merge 2 commits into from
Closed

Fix test paths with spaces #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7fa5fa
Fix test paths with spaces
BoldNewMedia Jun 30, 2026
31ec05c
Avoid trailing slash in e2e repo root
BoldNewMedia Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 40 additions & 37 deletions tests/commands.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@ import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { execFileSync, spawnSync } from "node:child_process";
import { fileURLToPath } from "node:url";
import test from "node:test";

const companion = new URL("../plugins/claude-code-advisor/scripts/claude-companion.mjs", import.meta.url);
const companion = fileURLToPath(
new URL("../plugins/claude-code-advisor/scripts/claude-companion.mjs", import.meta.url)
);

function makeFakeClaude(scriptBody) {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "fake-claude-"));
Expand Down Expand Up @@ -44,7 +47,7 @@ if (args.includes("-p")) { console.log("{}"); process.exit(0); }
console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const stdout = execFileSync(process.execPath, [companion.pathname, "setup", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "setup", "--json"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand Down Expand Up @@ -73,7 +76,7 @@ console.error("unsupported"); process.exit(2);
CLAUDE_COMPANION_STATE_ROOT: stateRoot,
CODEX_THREAD_ID: "thread-a"
};
const stdout = execFileSync(process.execPath, [companion.pathname, "review", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "review", "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -83,7 +86,7 @@ console.error("unsupported"); process.exit(2);
assert.equal(payload.status, "completed");
assert.equal(payload.result.findings[0].severity, "MAJOR");

const result = execFileSync(process.execPath, [companion.pathname, "result", payload.jobId, "--json"], {
const result = execFileSync(process.execPath, [companion, "result", payload.jobId, "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -105,7 +108,7 @@ console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const env = { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot };
const stdout = execFileSync(process.execPath, [companion.pathname, "advise", "--background", "check architecture", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "advise", "--background", "check architecture", "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -115,15 +118,15 @@ console.error("unsupported"); process.exit(2);
assert.equal(payload.status, "running");
assert.equal(payload.claudeSessionId, "bg123");

const cancel = execFileSync(process.execPath, [companion.pathname, "cancel", payload.jobId, "--json"], {
const cancel = execFileSync(process.execPath, [companion, "cancel", payload.jobId, "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
});
assert.equal(JSON.parse(cancel).status, "cancelled");
assert.equal(fs.readFileSync(stopLog, "utf8"), "bg123");

const result = execFileSync(process.execPath, [companion.pathname, "result", payload.jobId, "--json"], {
const result = execFileSync(process.execPath, [companion, "result", payload.jobId, "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -149,7 +152,7 @@ if (args.includes("-p")) {
console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const stdout = execFileSync(process.execPath, [companion.pathname, "review", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "review", "--json"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -170,15 +173,15 @@ console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const env = { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot };
const launched = execFileSync(process.execPath, [companion.pathname, "advise", "--background", "check architecture", "--json"], {
const launched = execFileSync(process.execPath, [companion, "advise", "--background", "check architecture", "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
});
const job = JSON.parse(launched);
const watched = execFileSync(
process.execPath,
[companion.pathname, "monitor", job.jobId, "--interval-ms", "1", "--max-checks", "2", "--json"],
[companion, "monitor", job.jobId, "--interval-ms", "1", "--max-checks", "2", "--json"],
{ env, cwd: stateRoot, encoding: "utf8" }
);
const snapshots = watched.trim().split(/\r?\n/).map((line) => JSON.parse(line));
Expand All @@ -187,7 +190,7 @@ console.error("unsupported"); process.exit(2);
assert.equal(snapshots[0].active, true);
assert.equal(snapshots[0].logs.output, "progress: still working");

const result = execFileSync(process.execPath, [companion.pathname, "result", job.jobId, "--json"], {
const result = execFileSync(process.execPath, [companion, "result", job.jobId, "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand Down Expand Up @@ -215,7 +218,7 @@ console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const env = { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot };
const launched = execFileSync(process.execPath, [companion.pathname, "advise", "--background", "check architecture", "--json"], {
const launched = execFileSync(process.execPath, [companion, "advise", "--background", "check architecture", "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -224,7 +227,7 @@ console.error("unsupported"); process.exit(2);
const watched = execFileSync(
process.execPath,
[
companion.pathname,
companion,
"monitor",
job.jobId,
"--interval-ms",
Expand All @@ -248,7 +251,7 @@ console.error("unsupported"); process.exit(2);

const human = execFileSync(
process.execPath,
[companion.pathname, "monitor", job.jobId, "--interval-ms", "1", "--max-checks", "1"],
[companion, "monitor", job.jobId, "--interval-ms", "1", "--max-checks", "1"],
{ env, cwd: stateRoot, encoding: "utf8" }
);
assert.match(human, /Last meaningful output: progress: compiling tests/);
Expand Down Expand Up @@ -280,13 +283,13 @@ console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const env = { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot };
const launched = execFileSync(process.execPath, [companion.pathname, "advise", "--background", "check architecture", "--json"], {
const launched = execFileSync(process.execPath, [companion, "advise", "--background", "check architecture", "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
});
const job = JSON.parse(launched);
const watched = execFileSync(process.execPath, [companion.pathname, "monitor", job.jobId, "--json"], {
const watched = execFileSync(process.execPath, [companion, "monitor", job.jobId, "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -298,7 +301,7 @@ console.error("unsupported"); process.exit(2);
assert.equal(snapshot.summary.state, "inactive");
assert.equal(snapshot.summary.lastMeaningfulLine, "PASS");

const result = execFileSync(process.execPath, [companion.pathname, "result", job.jobId, "--json"], {
const result = execFileSync(process.execPath, [companion, "result", job.jobId, "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -311,7 +314,7 @@ console.error("unsupported"); process.exit(2);
test("foreground advise defaults to a larger turn budget", () => {
const fake = makeFakeClaudeExpectingMaxTurns(20);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const stdout = execFileSync(process.execPath, [companion.pathname, "advise", "check architecture", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "advise", "check architecture", "--json"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -325,7 +328,7 @@ test("foreground advise defaults to a larger turn budget", () => {
test("foreground do defaults to a larger turn budget", () => {
const fake = makeFakeClaudeExpectingMaxTurns(20);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const stdout = execFileSync(process.execPath, [companion.pathname, "do", "inspect local code", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "do", "inspect local code", "--json"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -339,7 +342,7 @@ test("foreground do defaults to a larger turn budget", () => {
test("foreground rescue defaults to a larger turn budget", () => {
const fake = makeFakeClaudeExpectingMaxTurns(20);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const stdout = execFileSync(process.execPath, [companion.pathname, "rescue", "diagnose the failure", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "rescue", "diagnose the failure", "--json"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -355,7 +358,7 @@ test("foreground task max-turn override takes precedence over the default", () =
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const stdout = execFileSync(
process.execPath,
[companion.pathname, "do", "--max-turns", "5", "inspect local code", "--json"],
[companion, "do", "--max-turns", "5", "inspect local code", "--json"],
{
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
Expand All @@ -378,7 +381,7 @@ if (args.includes("-p")) {
console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const stdout = execFileSync(process.execPath, [companion.pathname, "do", "inspect local code", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "do", "inspect local code", "--json"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -405,7 +408,7 @@ if (args.includes("-p")) {
console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const stdout = execFileSync(process.execPath, [companion.pathname, "advise", "check architecture", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "advise", "check architecture", "--json"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -431,7 +434,7 @@ if (args[0] === "--bg") {
console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const stdout = execFileSync(process.execPath, [companion.pathname, "advise", "--background", "check architecture", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "advise", "--background", "check architecture", "--json"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -453,7 +456,7 @@ console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
fs.writeFileSync(path.join(stateRoot, ".mcp.json"), '{"mcpServers":{"playwright":{}}}\n', "utf8");
const result = spawnSync(process.execPath, [companion.pathname, "advise", "--background", "check architecture", "--json"], {
const result = spawnSync(process.execPath, [companion, "advise", "--background", "check architecture", "--json"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -478,7 +481,7 @@ console.error("unsupported"); process.exit(2);
fs.mkdirSync(child, { recursive: true });
fs.writeFileSync(path.join(parent, ".mcp.json"), '{"mcpServers":{"playwright":{}}}\n', "utf8");
fs.writeFileSync(path.join(child, ".git"), "gitdir: ../.git/worktrees/task\n", "utf8");
const result = spawnSync(process.execPath, [companion.pathname, "advise", "--background", "check architecture", "--json"], {
const result = spawnSync(process.execPath, [companion, "advise", "--background", "check architecture", "--json"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: parent },
cwd: child,
encoding: "utf8"
Expand Down Expand Up @@ -506,7 +509,7 @@ console.error("unsupported"); process.exit(2);
fs.writeFileSync(path.join(stateRoot, ".mcp.json"), '{"mcpServers":{"playwright":{}}}\n', "utf8");
const stdout = execFileSync(
process.execPath,
[companion.pathname, "advise", "--background", "--allow-mcp", "check architecture", "--json"],
[companion, "advise", "--background", "--allow-mcp", "check architecture", "--json"],
{
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
Expand Down Expand Up @@ -534,7 +537,7 @@ if (args.includes("-p")) {
console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const stdout = execFileSync(process.execPath, [companion.pathname, "do", "inspect local code", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "do", "inspect local code", "--json"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -561,7 +564,7 @@ console.error("unsupported"); process.exit(2);
const env = { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot };
const stdout = execFileSync(
process.execPath,
[companion.pathname, "advise", "--timeout-ms", "50", "check architecture", "--json"],
[companion, "advise", "--timeout-ms", "50", "check architecture", "--json"],
{ env, cwd: stateRoot, encoding: "utf8" }
);
const payload = JSON.parse(stdout);
Expand All @@ -570,7 +573,7 @@ console.error("unsupported"); process.exit(2);
assert.equal(payload.claudeSessionId, "bg123");
assert.match(payload.output, /Foreground Claude timed out/);

const status = execFileSync(process.execPath, [companion.pathname, "status", payload.jobId, "--json"], {
const status = execFileSync(process.execPath, [companion, "status", payload.jobId, "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -589,7 +592,7 @@ console.error("unsupported"); process.exit(2);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const result = spawnSync(
process.execPath,
[companion.pathname, "advise", "--timeout-ms", "50", "--no-background-fallback", "slow"],
[companion, "advise", "--timeout-ms", "50", "--no-background-fallback", "slow"],
{
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
Expand All @@ -608,7 +611,7 @@ if (args.includes("-p")) { console.log("human answer"); process.exit(0); }
console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const stdout = execFileSync(process.execPath, [companion.pathname, "advise", "check architecture"], {
const stdout = execFileSync(process.execPath, [companion, "advise", "check architecture"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -633,7 +636,7 @@ console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const env = { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot };
const stdout = execFileSync(process.execPath, [companion.pathname, "rescue", "--write", "fix the failing test", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "rescue", "--write", "fix the failing test", "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -644,7 +647,7 @@ console.error("unsupported"); process.exit(2);
assert.equal(payload.status, "completed");
assert.equal(payload.output, "rescued");

const result = execFileSync(process.execPath, [companion.pathname, "result", payload.jobId, "--json"], {
const result = execFileSync(process.execPath, [companion, "result", payload.jobId, "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand All @@ -668,7 +671,7 @@ console.error("unsupported"); process.exit(2);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const env = { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot };
const stdout = execFileSync(process.execPath, [companion.pathname, "rescue", "diagnose the failure", "--json"], {
const stdout = execFileSync(process.execPath, [companion, "rescue", "diagnose the failure", "--json"], {
env,
cwd: stateRoot,
encoding: "utf8"
Expand Down Expand Up @@ -701,7 +704,7 @@ console.error("unsupported"); process.exit(2);
const env = { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot };
const stdout = execFileSync(
process.execPath,
[companion.pathname, "do", "--write", "--model", "sonnet", "implement the prepared task", "--json"],
[companion, "do", "--write", "--model", "sonnet", "implement the prepared task", "--json"],
{ env, cwd: stateRoot, encoding: "utf8" }
);
const payload = JSON.parse(stdout);
Expand All @@ -716,7 +719,7 @@ test("foreground timeout fails the job without hanging", () => {
setTimeout(() => {}, 5000);
`);
const stateRoot = fs.mkdtempSync(path.join(os.tmpdir(), "claude-state-"));
const result = spawnSync(process.execPath, [companion.pathname, "advise", "--timeout-ms", "50", "--no-background-fallback", "slow"], {
const result = spawnSync(process.execPath, [companion, "advise", "--timeout-ms", "50", "--no-background-fallback", "slow"], {
env: { ...process.env, PATH: `${fake.dir}:${process.env.PATH}`, CLAUDE_COMPANION_STATE_ROOT: stateRoot },
cwd: stateRoot,
encoding: "utf8"
Expand Down
4 changes: 3 additions & 1 deletion tests/e2e-codex-skill.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import assert from "node:assert/strict";
import { spawnSync } from "node:child_process";
import path from "node:path";
import { fileURLToPath } from "node:url";

const repoRoot = new URL("..", import.meta.url).pathname;
const repoRoot = path.dirname(fileURLToPath(import.meta.url));
const skillMarker = "claude-code-advisor:claude";
const advisePrompt = [
"Use $claude advise --model sonnet --max-turns 1 --timeout-ms 120000 to ask Claude Code to reply with exactly PASS.",
Expand Down