Skip to content

fix(helm): Add the missing max_concurrent_jobs config option for compression-coordinator in the values file. - #2495

Merged
LinZhihao-723 merged 4 commits into
y-scope:mainfrom
LinZhihao-723:add-missing-value
Aug 25, 2026
Merged

fix(helm): Add the missing max_concurrent_jobs config option for compression-coordinator in the values file.#2495
LinZhihao-723 merged 4 commits into
y-scope:mainfrom
LinZhihao-723:add-missing-value

Conversation

@LinZhihao-723

@LinZhihao-723 LinZhihao-723 commented Aug 24, 2026

Copy link
Copy Markdown
Member

Description

In #2435, we introduced a new config option named max_concurrent_jobs for compression-coordinator. However, the values file is not updated as a part of that PR. This PR fixes this issue by adding this missing option in the values file.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Ensure all workflows pass.

Summary by CodeRabbit

  • New Features

    • Added configuration for the maximum number of concurrent compression coordinator jobs, defaulting to 1,000.
  • Chores

    • Updated the deployment package version to the latest development release.

@LinZhihao-723
LinZhihao-723 requested a review from a team as a code owner August 24, 2026 01:07
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fc465386-c529-43e2-8cb0-9f5b083fac73

📥 Commits

Reviewing files that changed from the base of the PR and between 2030840 and ae7b72f.

📒 Files selected for processing (1)
  • tools/deployment/package-helm/templates/configmap.yaml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The Helm chart version was incremented to 0.4.1-dev.7. The chart now sets and renders max_concurrent_jobs as 1000 for the compression coordinator.

Changes

Helm chart update

Layer / File(s) Summary
Chart metadata and compression coordinator configuration
tools/deployment/package-helm/Chart.yaml, tools/deployment/package-helm/values.yaml, tools/deployment/package-helm/templates/configmap.yaml
The chart version changed from 0.4.1-dev.6 to 0.4.1-dev.7. The default max_concurrent_jobs value is 1000, and the ConfigMap renders it as an integer.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to ae7b7

This PR adds the missing Helm configuration for compression-coordinator without any identified merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: junhaoliao

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the missing Helm configuration option added to the values file and matches the main changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@20001020ycx 20001020ycx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the missing config is now propagated to the compression coordinator by spinning up the k8s cluster through kind.

@LinZhihao-723
LinZhihao-723 merged commit 919c344 into y-scope:main Aug 25, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants