Skip to content

feat(search-coordinator): Add initial scaffolding. - #2444

Draft
Bill-hbrhbr wants to merge 17 commits into
y-scope:mainfrom
Bill-hbrhbr:search-coordinator/init
Draft

feat(search-coordinator): Add initial scaffolding.#2444
Bill-hbrhbr wants to merge 17 commits into
y-scope:mainfrom
Bill-hbrhbr:search-coordinator/init

Conversation

@Bill-hbrhbr

Copy link
Copy Markdown
Contributor

Description

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LinZhihao-723 LinZhihao-723 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, this PR is too large and we should break it into small ones to tight the scope for better decision making. I would propose the following:

  • search_job_submitter with only the trait. The implementation depends on TDL. We can implement it for Spider client, but leave it with todo!.
  • job_handle implemention on top of search_job_submitter.
    • We probably need to split this mod even further (splitting into smaller PRs). Use todo! to define the interface first.
  • coordination implemention on top of job_handle.
  • bin implementation.

Assume tdl becomes available in parallel, the binary itself should be able to serve search jobs. We then plan to add the Python side and deployment integration.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether we need all of the schema changes in this file. In the formal PR, we should document why we need to add a new column.

}

tracing::info!("Coordinator shutting down.");
tracing::info!("Compression coordinator shutting down.");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants