feat(search-coordinator): Add initial scaffolding. - #2444
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…r's config map section.
LinZhihao-723
left a comment
There was a problem hiding this comment.
As discussed offline, this PR is too large and we should break it into small ones to tight the scope for better decision making. I would propose the following:
search_job_submitterwith only the trait. The implementation depends on TDL. We can implement it for Spider client, but leave it withtodo!.job_handleimplemention on top ofsearch_job_submitter.- We probably need to split this mod even further (splitting into smaller PRs). Use
todo!to define the interface first.
- We probably need to split this mod even further (splitting into smaller PRs). Use
coordinationimplemention on top ofjob_handle.binimplementation.
Assume tdl becomes available in parallel, the binary itself should be able to serve search jobs. We then plan to add the Python side and deployment integration.
There was a problem hiding this comment.
I'm not sure whether we need all of the schema changes in this file. In the formal PR, we should document why we need to add a new column.
| } | ||
|
|
||
| tracing::info!("Coordinator shutting down."); | ||
| tracing::info!("Compression coordinator shutting down."); |
Description
Checklist
breaking change.
Validation performed