Show the publisher line on the first-run About - #153
Merged
Conversation
The verdict comes off a background thread, and the check only started at the end of InitInstance, after the first-run About had opened and closed. That dialog could therefore never name a publisher, signed build or not. A new user met an empty band where the line belongs, and so did every documentation screenshot of that screen. Start the check once the main window exists, and let Cabout fill the row when the verdict arrives instead of only at open. Moving the start on its own would leave the row blank whenever chain building outruns the dialog, which is worse for being intermittent. A CI guard pins the ordering, since neither the build nor the selftest can see it. Closes #152 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
The source-order guard only pins where the call sits. A commented-out call at the new site with the real one restored at the end still passes it, and it cannot see the late fill in Cabout at all. The walk already opens that About and resolves controls by id, so assert IDC_SIGSTATUS is non-empty before shooting it. Reverting either half of the fix fails that. The wait raises a RuntimeError rather than a Timeout, because the enclosing handler reads a Timeout as "not a first run" and would pass. Also from review: OnTimer moves inside the ClassWizard block like its peers, the two tunables become static const, and three comments lose a line each. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signature verdict is computed on a background thread, and the check only started at the end of
InitInstance, after the first-run About had already opened and closed. So that dialog could never name a publisher, on a signed build or an unsigned one. It is the one a new user sees, and it is also00_language_preferencein the documentation set, which is how it surfaced.Both halves are needed. Start the check once the main window exists, and have
Caboutfill the row when the verdict lands rather than only at open. Moving the start alone would leave the row blank whenever chain building outruns the dialog.The screenshot walk opens that exact About, so it now asserts
IDC_SIGSTATUSis non-empty before shooting it: on CI the build is unsigned, so the row reads "Not signed: built from source, not an official release." Reverting either half fails it. A source-order guard in theencodingjob is the cheap companion, and I checked that it fails on the pre-fix source rather than assuming it would.Closes #152