Compute the crate hash from encoded metadata in non-incremental builds - #61
Draft
xmakro wants to merge 1 commit into
Draft
Compute the crate hash from encoded metadata in non-incremental builds#61xmakro wants to merge 1 commit into
xmakro wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crate hash is computed by stable-hashing the HIR. When nothing but the metadata needs it, hash the encoded metadata bytes instead: they are what downstream crates actually read, and they are already being written out.
-1.02% on non-incr full measurements (syn check -2.46%, serde -2.32%, hyper -2.01%, cargo -1.86%), tests/ui 21309 passed / 0 failed.
Prototype: the
CrateRoot's own fields are not covered by the hash yet, and only tests/ui has been run. Proc-macro crates keep the HIR hash, since their metadata is a stub.