Repository navigation
Conversation
xi-zhao
marked this pull request as ready for review
November 15, 2026 06:51
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI 曾因两类相同写法返修:在不支持
runner的 job 环境中引用临时目录,以及计算通过tee保存日志后丢失失败状态。本 PR 将这些已发生的问题变成可重复执行的检查;仅修改现有 CI 和测试,不修改 AGENTS.md、生产行为或科学阈值。问题与验收规格
runner.temp改到 step 内处理。验收:所有工作流接受语法、表达式和上下文检查,旧写法被拒绝。CI / quality与node --test tests/*.test.mjs;无新增工作流、调度器、生产依赖、宿主或模型设置变更。改动
tests/workflow-gates.test.mjs,读取三份真实 workflow 的数值步骤及其 shell 继承配置,按 GitHub 的 Bash 执行合同 运行实际日志管道。仅将外部计算进程替换成返回 0/23 的测试程序;禁止这三条验收路径用continue-on-error吞掉失败。固定 Linux 发行包摘要:
8aca8db96f1b94770f1b0d72b6dddcb1ebb8123cb3712530b08cc387b349a3d8,与官方校验表一致。未引入另一个手写的工作流解析器。验证
npm run lint、git diff --check审查与边界
固定 base:
508ed5cd05eb44276fd5009641efa7e82a3b70c0;head:ea2832c7a70e48d5d6bb1429139cb6f0f3f9a77e。单代理顺序自审(reviewMode=self-review、independent=false):Standards 通过,Spec 通过。已对照 AGENTS.md、CONTRIBUTING.md、当前架构合同和完整 smell baseline;没有新增阻断发现。设计复用现成检查器和现有测试入口;回归验证采用先失败后通过的有界步骤。远端 quality 日志确认新增的三组成功/失败测试均执行通过。主测试组 1257 项,其中 898 通过、359 条件跳过、0 失败;其余既有质量步骤亦通过,未把条件跳过计为实测成功。
这些测试证明工作流配置与失败传播,不证明量子数值正确性。数值计算仍由各库原有真实验证负责;本测试不安装或执行量子 SDK。actionlint 的可选 ShellCheck/Pyflakes 集成关闭,范围是工作流结构与表达式。三条 Bash 回归在 Linux/macOS 运行,Windows 跳过。未修改分支保护设置;检查失败会报告 CI 失败,是否阻止合并取决于仓库已有规则。
回退:撤销本 PR 的单个提交即可,用户环境、能力 pin、宿主适配和科学合同均不受影响。