Fix SDJWTVC Parser test that waited for a network fetch until timeout - #116
Merged
Conversation
pstamatop
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a failing SDJWTVCParser test case, which timed out awaiting a network fetch for issuer's metadata. Since the test case handles a credential without metadata, and the issuer does not provide any metadata, the httpClient for this test case has been replaced with a
metadataNotFoundHttpClientthat immediately returns 404.Additionally,
convertDataUriToImage()is no longer used to write the image to disk, as its output was never parsed. Success is implied by the image element starting with 'data:image/'.After the above changes, the test finishes far below the 5000ms threshold.