Conversation
WalkthroughThe README documentation for the gateway-controller was updated to reflect the supported storage types, removing Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@gateway/gateway-controller/README.md`:
- Line 100: README still lists "memory" as a supported storage type which
conflicts with the code (factory/validation only accept "sqlite" and
"postgres"); remove all remaining `memory` references and example blocks that
show `type: memory` (update the examples under storage, the config examples list
that mentions `config-memory-only.yaml`, and any code sample lines at the noted
locations) and replace with the correct supported types or a note that only
`sqlite` and `postgres` are supported so the docs match the behavior of the
storage factory/validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fe83e2a8-f17c-4a35-9cc2-da81213b0984
📒 Files selected for processing (1)
gateway/gateway-controller/README.md
| # Storage configuration | ||
| storage: | ||
| type: sqlite # "sqlite", "postgres", or "memory" | ||
| type: sqlite # "sqlite", "postgres" |
There was a problem hiding this comment.
Remove remaining memory references to keep storage docs consistent.
Line 100 is correct, but the README still documents memory as supported (Line 146, Lines 205-211, Line 258). That conflicts with actual validation/factory behavior (sqlite/postgres only) and will mislead users into invalid configs.
Suggested README cleanup
-# Set storage type to memory
-export APIP_GW_GATEWAY__CONTROLLER_STORAGE_TYPE=memory
-
-#### Memory-Only Mode
-No persistent storage (useful for testing):
-
-```yaml
-storage:
- type: memory
-```
-
-See `config/` directory for examples:
-- `config.yaml` - Default production configuration
-- `config-memory-only.yaml` - Testing/development configuration
+See `config/` directory for examples:
+- `config.yaml` - Default production configuration🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@gateway/gateway-controller/README.md` at line 100, README still lists
"memory" as a supported storage type which conflicts with the code
(factory/validation only accept "sqlite" and "postgres"); remove all remaining
`memory` references and example blocks that show `type: memory` (update the
examples under storage, the config examples list that mentions
`config-memory-only.yaml`, and any code sample lines at the noted locations) and
replace with the correct supported types or a note that only `sqlite` and
`postgres` are supported so the docs match the behavior of the storage
factory/validation.
Purpose
Goals
Approach
User stories
Documentation
Automation tests
Security checks
Samples
Related PRs
Test environment
Summary by CodeRabbit