Repository navigation
fix: replace hardcoded install scripts with unified generic versions - #39
Merged
Merged
Conversation
Adopt the unified install script approach from warcraft-rs. The scripts use environment variables (BINARY_NAMES, BINARY_DEFAULT, REPO, TAG_PREFIX) instead of hardcoded values, fixing the double-v bug in download URLs where TAG_PREFIX was incorrectly constructed. The CI workflow tests script functionality on all three platforms using cascette-ribbit as the default binary. Closes #26
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Remove quotes from right-hand side of =~ operator to match as regex rather than literal string. Uses escaped spaces for word boundaries.
Prevent main() from executing when the script is sourced (e.g., for testing individual functions like detect_platform). Only run main when the script is executed directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TAG_PREFIXwas incorrectly constructed, producing URLs like.../vv0.1.0/...instead of.../v0.1.0/...Changes
install.sh- Generic bash installer usingBINARY_NAMES,BINARY_DEFAULT,REPO,TAG_PREFIXenv varsinstall.ps1- Generic PowerShell installer with same env var approach.github/workflows/install-script.yml- CI workflow testing scripts on all platformsTest plan
install.sh--helpflag worksdetect_platformfunction worksbash -n) passesCloses #26