Add some missing length checks and fix length calculation.#10277
Open
kareem-wolfssl wants to merge 3 commits intowolfSSL:masterfrom
Open
Add some missing length checks and fix length calculation.#10277kareem-wolfssl wants to merge 3 commits intowolfSSL:masterfrom
kareem-wolfssl wants to merge 3 commits intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets length validation in handshake parsing/building to address reported issues (zd#21664, ZD#21665), aiming to prevent incorrect length calculations and out-of-bounds accesses in TLS/TLS 1.3 flows.
Changes:
- Add additional bounds checks when parsing TLS 1.3 ServerHello legacy session ID.
- Add missing bounds checks for PSK identity handling in
SendClientKeyExchange. - Adjust length accounting used to size remaining space for (EC)DHE-PSK key material.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/tls13.c | Tightens ServerHello legacy session ID length validation during TLS 1.3 parsing. |
| src/internal.c | Adds PSK identity size checks and updates remaining-length calculations for PSK-based key exchanges. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks to Zou Dikai for the report.
…lientKeyExchange. Thanks to Zou Dikai for the reports.
kareem-wolfssl
force-pushed
the
zd21664_5
branch
from
2344e24 to
768525c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#21664, ZD#21665
Testing
Built-in tests
Checklist